[Pkg-shadow-devel] python-4suite: Please quote the commands given to su

[Nicolas François]

Package: python-4suite
Version: 0.99cvs20060302-1
Severity: wishlist
Tags: patch

Hello,

As announced in [0], su behavior will change.
The python-4suite-server init.d executes commands with su without quoting
them.
(The attached patch also fixes a command in python-4suite's documentation.)

The patched version should be compatible with the old and future su.

You can find a login package in experimental if you want to test the
patch.

When the new login package will reach unstable, the severity of this bug
will be raised.

[0] http://lists.debian.org/debian-devel-announce/2006/03/msg00003.html

Kind Regards,
-- 
Nekral
-------------- next part --------------
diff -rauN ../orig/python-4suite-0.99cvs20060302/debian/patches/19-DebianQuickStart.dpatch ./python-4suite-0.99cvs20060302/debian/patches/19-DebianQuickStart.dpatch
--- ../orig/python-4suite-0.99cvs20060302/debian/patches/19-DebianQuickStart.dpatch	2006-03-25 18:44:31.000000000 +0100
+++ ./python-4suite-0.99cvs20060302/debian/patches/19-DebianQuickStart.dpatch	2006-03-25 18:54:54.000000000 +0100
@@ -61,7 +61,7 @@
 +	<para>Please read this Debian GNU/Linux reletaed paragraphs carefully. They affect the whole document.</para>
 +	<para>Tune your preferred configuration for the 4Suite RDF Controller (Server) using the /etc/defaults/4ss file.</para>
 +    <para>The 4ssd application has been moved to /usr/share/4Suite to comply File Hirarchy Standard (FHS) because this script is not stand-alone executable. You have to use 4ss_manager instead.</para>
-+    <para>The preferred way to run 4ss_manager is as user/gruop `ftss' which is automatically created on installation of python-4suite-server package. To do so start as root `# su ftss -c 4ss_manager init' or any of the other commands which modify the repository in /var/lib/4Suite directory.</para>
++    <para>The preferred way to run 4ss_manager is as user/gruop `ftss' which is automatically created on installation of python-4suite-server package. To do so start as root `# su ftss -c "4ss_manager init"' or any of the other commands which modify the repository in /var/lib/4Suite directory.</para>
 +    <para>The /etc/init.d/4ss will also start 4ssd as user/group `ftss'. This can be changed by DAEMON_USER in /etc/defaults/4ss.</para>
 +    <para>The PID and the LOG are stored within /var/run/4Suite/4ss.pid and /var/log/4Suite/4ss.log files until the defaults are changed in /etc/4Suite/4ss.conf. Do not forget to change the /etc/default/4ss file too.</para>
 +  </section>
diff -rauN ../orig/python-4suite-0.99cvs20060302/debian/python-4suite-server.init.d ./python-4suite-0.99cvs20060302/debian/python-4suite-server.init.d
--- ../orig/python-4suite-0.99cvs20060302/debian/python-4suite-server.init.d	2006-03-25 18:44:31.000000000 +0100
+++ ./python-4suite-0.99cvs20060302/debian/python-4suite-server.init.d	2006-03-25 19:52:57.000000000 +0100
@@ -91,7 +91,7 @@
   stop)
 	echo -n "Stopping $DESC: "
 	if [ \( -n "$FTSS_USERNAME" -a -n "$FTSS_PASSWORD" \) -o "$DAEMON_STOPOPTIONS" != "stop" ]; then
-		su "$DAEMON_USER" -c "$DAEMON" $DAEMON_STOPOPTIONS 2>&1 >/dev/null
+		su "$DAEMON_USER" -c "\"$DAEMON\" $DAEMON_STOPOPTIONS >/dev/null 2>&1"
 		sleep 1
 		[ -r "$PIDFILE" ] && echo "FAILED." || echo "$NAME."
 	else
@@ -118,7 +118,7 @@
 	#
 	echo -n "Restarting $DESC: "
 	if [ \( -n "$FTSS_USERNAME" -a -n "$FTSS_PASSWORD" \) -o "$DAEMON_RESTARTOPTIONS" != "restart" ]; then
-		su "$DAEMON_USER" -c "$DAEMON" $DAEMON_RESTARTOPTIONS 2>&1 >/dev/null
+		su "$DAEMON_USER" -c "\"$DAEMON\" $DAEMON_RESTARTOPTIONS >/dev/null 2>&1"
 		[ -r "$PIDFILE" ] && echo "$NAME." || echo "FAILED."
 	else
 		echo "UNCONFIGURED."