[Pkg-shadow-devel] Bug#359163: shadow: Please read /etc/default/locale when logging in

[Denis Barbier]

Package: shadow
Severity: wishlist
Tags: patch

Hi,

the locales package currently puts locale variables into
/etc/environment, but this will change very soon, variables
will be kept into a dedicated /etc/default/locale file.
This transition will be handled by the locales package
(variables have to be moved from one file to another), but
/etc/pam.d/{su,login} have to be patched too in order to
read /etc/default/locale.  Here is a patch.  I checked that
everything works fine when /etc/default/locale does not
exist.
Please apply so that we can modify the locales package without
breaking users' settings.
Thanks.

Denis
-------------- next part --------------
diff -ur shadow-4.0.15.orig/debian/login.pam shadow-4.0.15/debian/login.pam
--- shadow-4.0.15.orig/debian/login.pam	2006-03-26 23:16:01.000000000 +0200
+++ shadow-4.0.15/debian/login.pam	2006-03-26 23:20:13.000000000 +0200
@@ -20,6 +20,8 @@
 # 
 # parsing /etc/environment needs "readenv=1"
 session       required   pam_env.so readenv=1
+# locale files are kept into /etc/default/locale in etch
+session       required   pam_env.so readenv=1 envfile=/etc/default/locale
 
 # Standard Un*x authentication.
 @include common-auth
diff -ur shadow-4.0.15.orig/debian/login.su.pam shadow-4.0.15/debian/login.su.pam
--- shadow-4.0.15.orig/debian/login.su.pam	2006-03-26 23:16:01.000000000 +0200
+++ shadow-4.0.15/debian/login.su.pam	2006-03-26 23:19:37.000000000 +0200
@@ -34,6 +34,8 @@
 # 
 # parsing /etc/environment needs "readenv=1"
 session       required   pam_env.so readenv=1
+# locale files are kept into /etc/default/locale in etch
+session       required   pam_env.so readenv=1 envfile=/etc/default/locale
 
 # Defines the MAIL environment variable
 # However, userdel also needs MAIL_DIR and MAIL_FILE variables