[Pkg-shadow-devel] redhat patches

[Nicolas François]

Hi,

On Tue, Nov 13, 2007 at 10:58:59AM +0100, Peter Vrabec wrote:
> 
> do you mind to look at some redhat patches, which might be interesting to 
> commit?

See below.

> I'm sending one example. It's fixing this problem:
> 
> If you have a group file that looks something like the following:
> badgroup:x:30266:root
> badgroup::30266:root,deleteme
> deleteme:x:20750:
> And you try to "userdel deleteme", userdel will go into an endless loop.

As it fixes this issue, it shall be included upstream.
I will have a look.

> Also I'd like to ask:
> You fixed getgr_nam_gid() in usermod.c but didn't do the same in useradd.c. Is 
> there any reason?

The part in usermod was already fixed in the PLD CVS, but useradd was not
fixed.
I haded very few changes between the PLD CVS and 4.0.18.2.

I also noticed this one later when preparing the Debian package.

This will be fixed in 4.0.19.


Here are some comments on the RedHat patches (based on
shadow-utils-4.0.18.1-13.fc7.src.rpm):
 * shadow-4.0.11.1-vipw.patch
   Is it still needed?
   What are /etc/ptmp and /tmp/gtmp?
   Are they standard lock files used by other common/recent software?
 * shadow-4.0.13-newgrpPwd.patch
   I've committed the part which implement the following comment:
   /* note: the original util-linux newgrp didn't ask for
    * pasword if there is no password. It's better directly give up.
    * -- kzak at redhat.com
    */
   I don't think the rest of the patch introduce any functionnal change.
   Am I wrong?
 * shadow-4.0.14-goodname.patch
   RedHat specific (we have something similar for Debian).
   I'm not sure about the chunk:
   -    if (strlen (name) > sizeof (ut.ut_user))
   +    if (strlen(name) + 1 > sizeof(ut.ut_user))
   Not sure neither for the group name length.
   I will keep it for latter.
 * shadow-4.0.16-lOption.patch
   This adds a new useradd option.
   This will make the useradd implementation incompatible with other
   implementation, but people are free not to use that option.
   I think I will commit it.
 * shadow-4.0.16-nscd.c
   Why is the current nscd_flush_cache implementation not sufficient?
 * shadow-4.0.17-auditLogging.patch
   Fixed by Tomasz => in 4.0.18.2
 * shadow-4.0.17-exitValues.patch
   Also fixed in 4.0.18.2
 * shadow-4.0.17-login.defs
   Config file => IMO, they have to be tuned by distributors
   I will check later if upstream shall config files shall be updated.
 * shadow-4.0.17-notInheritFd.patch
   Only useful when shadow-4.0.16-nscd.c is used?
   Upstream implementation does not execve, but uses a socket.
 * shadow-4.0.17-redhat.patch
   The oflg stuff is not needed (find_new_uid is always protected by
   !oflg). Maybe an assert could be nice.
   For the main part of the patch (new options), it seems to be controversial.
   My opinion is that they should be included, maybe with a note that
   software willing to be compatible with other implementation shall not
   use these options.
 * shadow-4.0.17-useradd.patch
   I would prefer to have some kind of script or a set of script in a
   directory for this.
   To be checked later.
 * shadow-4.0.18.1-appendOption.patch
   Fixed in 4.0.18.2
 * shadow-4.0.18.1-gid.patch
   Fixed in 4.0.18.2 + 4.0.19
 * shadow-4.0.18.1-overflow.patch
   Committed. (maybe with some indentation changes).
 * shadow-4.0.18.1-sysAccount.patch
   I don't remember;)
   Probably has to be checked again after inclusion of
   shadow-4.0.17-redhat.patch
 * shadow-4.0.18.1-useradd
   Config file
 * shadow-4.0.3-noinst.patch
   Distribution specific (but I'm not sure there is a distribution which
   choose to distribute the shadow library).

Kind Regards,
-- 
Nekral