[Pkg-shadow-devel] Bug#451521: small logging improvement to login

[Nicolas François]

tags 451521 fixed-upstream
thanks

Hello,

On Fri, Nov 16, 2007 at 03:42:32PM +0100, tnagel at e18.physik.tu-muenchen.de wrote:
> 
> I'm sending a small patch to improve logging of login.  When getpwnam() fails inside the PAM section, login
> would just silently quit, which caused me a considerable amount of pain while debugging my setup.  I thought,
> I'd help avoid others falling into that trap in the future.

Thanks for the patch.

I did not apply this patch, but another which should also solve your
issue.

 * setup_groups already log information about the issue, so an additional
   log is not required.
 * if the password entry could not be retrieved, it is not recommended to
   log the username: users sometimes enter their password instead of
   login.
   This is the default behavior, which can be turned off with
   LOG_UNKFAIL_ENAB in /etc/login.defs.

Please find attached the patch applied upstream for the next version.
-- 
Nekral
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shadow_login_log.patch
Type: text/x-diff
Size: 224 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20071117/3a87bc82/attachment.patch