[Pkg-shadow-devel] Small fixes in salt.c, chpasswd.c, chgpasswd.c

[Dan Kopecek]

Nicolas François wrote:
> On Fri, Nov 23, 2007 at 01:12:11PM +0100, Dan Kopecek wrote:
>> Hi,
>>  this patch adds a function for generating salt of given size and fixes
>> few bugs.
> 
> Thanks a lot.
> I will commit it tonight.
> 
> I will probably also:
>  * move the srandom call from crypt_make_salt to gensalt
>  * replace the if in gensalt by an assert
> 
> BTW, did you try chpasswd/su with the SHA256 or SHA512 algorithms?
> 
> I still have to install a newer libc to test it (I plan to do it this
> weekend).
> 
> 
> Best Regards,

I found a new problem, updated patch attached, please review it - I am
not sure if it is a feature or bug. I checked the return value of
crypt_make_salt when SHA256/512 is used and it should be ok (sha256:
"$5$rounds=num$salt" or "$5$salt" when *ROUNDS are not specified in
login.defs) but I didn't tested it with new libc too...

Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: shadow-utils-4.0.18.2-salt.patch
Type: text/x-patch
Size: 5364 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20071123/77f86564/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 282 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20071123/77f86564/attachment.pgp