[Pkg-shadow-devel] shadow-4.1.2.1 and uclibc

[Nicolas François]

On Mon, Aug 25, 2008 at 01:24:37PM +0200, tp at fonz.de wrote:
> Hello,
> 
> the current shadow package doesn't compile on uclibc. I haven't found
> a patch that addresses the issues, so I tried fixing them myself. A
> patch is attached.

Thanks a lot.
I don't have time to specifically target uclibc, but such patch is always
welcome.

> - struct stat.st_atim
> 
>   Test for _BSD_SOURCE and _SVID_SOURCE in copydir.c didn't work,
>   so I added an explicit test for st_atim to configure.in.
> 
>   I also found that mail.c uses st_atime. It's not guarded with a
>   test, though.

I don't really understand why the current test does not work, but testing
explicitly for the existence of the st_atim member does not harm.

mail.c looks OK. There are no st_mtim equivalent for the modification time

> - futimes, lutimes
>   uclibc doesn't seem to have these functions. I think futimes
>   can be replaced with utimes in copydir.c
> 
> - nscd
>   not present, I added --with-nscd (default: yes).
> 
> - posix_spawn
>   not present, but no problem when using --without-nscd.
> 
> - uid_t, gid_t
>   require <sys/types.h> in pwio.h and groupio.h

This sounds strange to me to include <sys/types.h> before <pwd.h> for the
definition of uid_t.
pwd.h should define the struct passwd structure, which contain a uid_t
member.

I can, add <sys/types.h> anyway, but it could be worth checking if it is
not a ulibc bug.

Cheers,
-- 
Nekral