[Pkg-shadow-devel] segfault in groupmems

[Nicolas François]

Hi Peter,

On Tue, Aug 26, 2008 at 12:25:18PM +0200, pvrabec at redhat.com wrote:
> Hi folks,
> 
> I get segfault in groupmems in shadow-4.1.2:
> 
> # grep frankl /etc/group
> frankl:x:501:frankl,root
> # ./groupmems -g frankl -a foo
> Segmentation fault
> 
> Problem found by Chris Goetschius  (goetschius at gmail.com )
> https://bugzilla.redhat.com/show_bug.cgi?id=459817

Did you manage to reproduce the first issue (-d does not remove the user?)

Here is a patch to fix the segfault.

This is fixed differently in SVN (I wanted to reuse the functions to
access lists, which fixed this bug at the same time)

The patch should still be OK, and pretty simple for 4.1.2.

Note: the SVN version adds support for shadow group to groupmems.

There is also another fix for groupmems, which is only important for users
who use shadow configured with PAM support (in 4.1.2, groupmems use the
groupmod service instead of groupmems (/etc/pam.d/groupmems))

I also started the groupmems tests suite.

Best Regards,
-- 
Nekral
-------------- next part --------------
A non-text attachment was scrubbed...
Name: groupmems_segfault.patch
Type: text/x-diff
Size: 878 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20080901/d0b482ef/attachment.patch