[Pkg-shadow-devel] shadow-126.96.36.199 and uclibc
nicolas.francois at centraliens.net
Sun Sep 7 00:17:38 UTC 2008
On Mon, Aug 25, 2008 at 01:24:37PM +0200, tp at fonz.de wrote:
> the current shadow package doesn't compile on uclibc. I haven't found
> a patch that addresses the issues, so I tried fixing them myself. A
> patch is attached.
Thanks for the patch. It's now applied to the shadow repository.
> - struct stat.st_atim
> Test for _BSD_SOURCE and _SVID_SOURCE in copydir.c didn't work,
> so I added an explicit test for st_atim to configure.in.
I've added a similar test for st_mtim.
(and the st_atimensec/st_mtimensec field)
> I also found that mail.c uses st_atime. It's not guarded with a
> test, though.
st_atime should always be present.
Also, I don't think a µsec resolution is needed for checking is there is
> - futimes, lutimes
> uclibc doesn't seem to have these functions. I think futimes
> can be replaced with utimes in copydir.c
Shouldn't utimes be called only after the file is closed?
I really wonder if the futimes call is valid (i.e. could the later call to
close() change the modification time?)
More information about the Pkg-shadow-devel