[Pkg-shadow-devel] [pkg-shadow-Bugs][311108] build failure with missing uid_t, gid_t (PATCH included)

[pkg-shadow-bugs at alioth.debian.org]

Bugs item #311108, was opened at 18/09/2008 11:52
>Status: Closed
Priority: 3
Submitted By: Thomas Orgis (sobukus-guest)
Assigned to: Nobody (None)
Summary: build failure with missing uid_t, gid_t (PATCH included) 
Category: None
Group: None
Resolution: None


Initial Comment:
Failure with gcc-4.2.3 and (yes, it's old...) glibc 2.3.6 on a Source Mage GNU/Linux (SMGL) system.

gcc -DHAVE_CONFIG_H -I. -I.. -I../lib    -march=athlon-xp -mmmx -mfpmath=sse -msse -m3dnow -pi
pe -O2 -MT xgetpwnam.o -MD -MP -MF .deps/xgetpwnam.Tpo -c -o xgetpwnam.o xgetpwnam.c
In file included from xgetpwnam.c:52:
../lib/pwio.h:37: error: expected ')' before 'uid'
make[2]: *** [xgetpwnam.o] Error 1
make[2]: Leaving directory `/usr/src/shadow-4.1.2.1/libmisc'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/shadow-4.1.2.1'

This did not occur on SMGL systems where I upgraded glibc, so it may be special to that version of /usr/include/pwd.h and grp.h.
Anyhow, the fix to make the build work again is simple:

#include <config.h>

is missing in the xget*.c files.
My attached patch fixes that. 'd be thankful for inclusion.

----------------------------------------------------------------------

>Comment By: Nicolas FRANCOIS  (nekral-guest)
Date: 18/09/2008 18:58

Message:
This is now fixed in subversion.

#include <sys/types.h>
was also added in some places before
#include <pwd.h>
(like lib/pwio.h) to add support for uclibc.

----------------------------------------------------------------------

You can respond by visiting: 
http://alioth.debian.org/tracker/?func=detail&atid=411478&aid=311108&group_id=30580