[Pkg-shadow-devel] packaging next 4.1.3

[Peter Vrabec]

On Saturday 11 April 2009 08:51:48 pm Nicolas François wrote:
> Hi Peter,
>
> On Wed, Apr 08, 2009 at 12:00:25PM +0200, pvrabec at redhat.com wrote:
> > I have packaged next 4.1.3 and made some clean up with patches.
> > Everything seems to be OK, but I have two patches that could upstream
> > consider for inclusion.
>
> I applied the two patches.
>
> > selinux.patch: add -Z option to map selinux user for user's login
>
> Here are some comments (I think they can wait for a later release):
>
>  * newusers should also have such option. I've added a TODO item.
>  * I only called selinux_update_mapping() when Zflg is set.
>    This does not change anything currently, but could be easier to
> maintain.
>  * selinux_file_context should be moved out of libmisc/copydir.c. I've
>    added a TODO item.
OK
>
>  * You added setfscreatecon (NULL) in copy_tree() (libmisc/copydir.c).
>    Do you think it would be better to just call selinux_file_context() in
>    copy_tree() or shall we also call setfscreatecon (NULL) from each of
>    the copy_*() functions.
I would say that we can call selinux_file_context() from copy_tree().

>  * Can you check the header of libmisc/system.c?
>    I was not sure who I should assign the copyright to.
You can assign it to Dan Walsh <dwalsh at redhat.com>

>  * In usermod, in case a user is renamed, Isn't there a need to call
>    semanage twice (to remove the mapping of the old username and map the
>    new username).
>    user_newname should be used in selinux_update_mapping ()
It sounds reasonable. We probably forgot to count with this case. My ToDo. :)

>  * It could be nice to the useradd, usermod, userdel selinux helpers to
>    libmisc
Agree.

>
>  * I did not include selinux/selinux.h in lib/defines.h. This does not
>    look necessary.
OK.

>
> Best Regards,