[Pkg-shadow-devel] Bug#505071: Bug#505071: closed ... fixed in shadow 1:4.1.3-1

[Nicolas François]

Hello,

On Sat, Apr 18, 2009 at 04:28:57PM +1000, psz at maths.usyd.edu.au wrote:
> 
> Is shadow used on non-Linux or non-PAM machines: do you need to worry
> about code within the likes of
> #ifndef USE_PAM
> ...
> #endif
> #ifdef __linux__
> #else
> ...
> #endif
> ?

shadow is used on non-PAM machines.

I know that the previous maintainer used shadow on non-Linux machine
(Solaris or OpenSolaris?), although I'm not sure it's widely distributed
(other distributions / UNIXes have shadow tool equivalents)

Getting rid of __linux__ for utmp.c would be nice. I don't think it really
makes sense to make a difference based on linux. I would prefer to make a
difference based on the availability of fields in the utmp structure (e.g.
IIRC BSD system have no ut_id field, which could change the way entries
should be searched / registered).
One difference with linux might be that it supports both UTMP and UTMPX,
but they are equivalent so there is no need to do both UTMP and UTMPX.
In that case, I would just prefer to remove HAVE_UTMPX from linux builds,
but have a single source in utmp.c

> If yes, I guess the final endpwent() group in login.c should be moved up
> to before setup_uid_gid().

Agreed (even "if no"). The necessary structures should have been copied
before (this would have to be checked).

Best Regards,
-- 
Nekral