[Pkg-shadow-devel] Bug#524873: login: lastlog is b0rked

[Sven Joachim]

Package: login
Version: 1:4.1.3.1-1
Severity: important
Tags: patch

The lastlog command is completely broken, it will always print that no
user ever logged in.  That's because it prints the login information
before it reads it, which can be rectified by the following patch:

--8<---------------cut here---------------start------------->8---
--- lastlog.c~	2009-03-14 00:29:14.000000000 +0100
+++ lastlog.c	2009-04-20 15:07:15.309514537 +0200
@@ -266,8 +266,7 @@
 		exit (1);
 	}
 
-	print ();
-	/* Get the laslog size */
+	/* Get the lastlog size */
 	if (fstat (fileno (lastlogfile), &statbuf) != 0) {
 		fprintf (stderr,
 		         _("lastlog: Cannot get the size of %s: %s\n"),
@@ -275,6 +274,7 @@
 		exit (1);
 	}
 
+	print ();
 	fclose (lastlogfile);
 	exit (0);
 }
--8<---------------cut here---------------end--------------->8---


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.28.9-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages login depends on:
ii  libc6                         2.9-7      GNU C Library: Shared libraries
ii  libpam-modules                1.0.1-9    Pluggable Authentication Modules f
ii  libpam-runtime                1.0.1-9    Runtime support for the PAM librar
ii  libpam0g                      1.0.1-9    Pluggable Authentication Modules l

login recommends no packages.

login suggests no packages.

-- no debconf information