[Pkg-shadow-devel] (no subject)

[brian]

I used the pscan utility on some of the source files for the
login/shadow package (the lenny src), and received this error:

login.c:613 SECURITY: snprintf call should have "%s" as argument 2
login.c:613 FUNC snprintf Last argument is variable or reference: BAD

I managed to get it to go away by changing this:
 613                                 snprintf (loginprompt,
 614                                           sizeof (loginprompt),
 615                                           _("login: "));

to this
 613                                 int short nohostn="unknown host";
 614                                 snprintf (loginprompt,
 615                                           sizeof (loginprompt),
 616                                           _("%d login: "), nohostn);

I figured the chances of someone not having noticed this was remote,
but what the hell.