[Pkg-shadow-devel] group with many users

[Nicolas François]

Hi,

On Tue, Jun 09, 2009 at 10:17:26AM +0200, pvrabec at redhat.com wrote:
> 
> what do you thing should be good setting for MAX_LENGTH in:
> 
> xgetgrgid.c
> xgetgrnam.c
> xgetpwnam.c
> xgetpwuid.c
> xgetspnam.c
> 
> I'm asking because of this bug report
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=501739
> 
> Current value 0x800 allows less then 1000 users with name length 8characters 
> in one group. 

I think I introduced MAX_LENGTH just to put a limit to the do...while
loop. But there is probably no reason to put a limit here.

Here is a first patch, which removes the limits from xgetXXbyYY.c.
(the limit is now based on the size_t type)

There is also an issue with the gshadow handling which silently breaks the
entries with lines more than 32k long (BUFSIZE * 4).

Best Regards,
-- 
Nekral
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shadow_large_groups.patch
Type: text/x-diff
Size: 4857 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20090611/31255287/attachment.patch>