[Pkg-shadow-devel] Bug#547079: Bug#547079: login: Should set the iutf8 tty c_iflag if the locale is utf8
vapier at gentoo.org
Fri Sep 18 00:35:16 UTC 2009
On Thursday 17 September 2009 19:59:14 Samuel Thibault wrote:
> Mike Frysinger, le Thu 17 Sep 2009 19:30:02 -0400, a écrit :
> > > > login/pam are there to do authentication only, not screw with the
> > > > terminal.
> > >
> > > Login already does screw with the terminal in setup_tty(),
> > presumably enough to prevent echoing of the password, but that's about it
> > (for obvious security reasons).
> Have you looked at the code before saying that?
> * Add your favorite terminal modes here ...
> termio.c_lflag |= ISIG | ICANON | ECHO | ECHOE;
> termio.c_iflag |= ICRNL;
looks like a lot of stuff login shouldnt be doing, but historically has been
so no one complained because "it worked". extending poor behavior because
it's already there isnt really a good line of reasoning.
> > i dont have a fedora box myself, but from talking to a friend, things
> > "just work" in the default setup. or at least it defaults everything
> > to unicode.
> Did he check whether stty -a properly shows iutf8? Things work very
> fine even without it, one of the very few effects of iutf8 left cleared
> is the bug I mentioned in my report: canonical mode's treatment of
> backspace. People rarely notice it.
i didnt ask him "hey does your keyboard work", i asked him what his settings
were after he logged in. so of course i validated the stty output.
i'm not suggesting everything is great and nothing needs to be changed. i'm
saying that login/pam is not really part of the solution.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: This is a digitally signed message part.
More information about the Pkg-shadow-devel