[Pkg-shadow-devel] files with ACLs in skel dir

Nicolas François nicolas.francois at centraliens.net
Wed Mar 31 09:29:52 UTC 2010

Hi Peter,

Sorry for the long delay.
I had a second look at the patch and would like to propose some changes.

It seems that the perm_copy_file() API is preferred to
acl_get_file()/acl_set_file(). (I've read it is because of the handling of
file system where ACL are not supported)
perm_copy_file() also makes it easier to set the ACLs (it's much more
similar to the calls of chmod)

Would you agree with the attached patch?
(Also, would it reduce the ACL support portability?)

The patch also adds support for preserving extended attributes (which will
include preserving the SELinux extended attributes).
Is this a bad idea? I remember you sent me a patch for the SELinux support
in copy_tree(). This used to set the default SELinux file context before
files / directories were created. Does it conflict with copying the
extended attributes?

Note: the patch is not yet tested (either for compilation or in runtime).

Best Regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shadow-acl.diff
Type: text/x-diff
Size: 12211 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20100331/4a2b9626/attachment.diff>

More information about the Pkg-shadow-devel mailing list