[Pkg-shadow-devel] Good day! May be i found small bug :)

[Павел Владимирович Самсонов]

I work on Slackware Linux 13.1 with shadow package shadow-4.1.4.2.
Slackware not a PAM distributive.
Bug found when console login user with more 16 suplementary groups. The
Function add_groups failed when getting user's groups. 
May be this patch:

--- ./shadow-4.1.4.2.orig/libmisc/addgrps.c	2009-04-06 02:29:44.000000000 +0400
+++ ./shadow-4.1.4.2/libmisc/addgrps.c	2011-04-14 13:36:33.000000000 +0400
@@ -71,7 +71,7 @@
 			return -1;
 		}
 		ngroups = getgroups (i, grouplist);
-		if ((-1 == ngroups) || (i > (size_t)ngroups)) {
+		if (ngroups != -1) {
 			break;
 		}
 		/* not enough room, so try allocating a larger buffer */

Thanks! Sorry My English :).