[Pkg-shadow-devel] Bug#659957: login: login at console no longer updates utmp

[Jakub Wilk]

* Christian PERRIER <bubulle at debian.org>, 2012-04-22, 18:48:
>>Any news on this bug?
>Well, Nicolas is *very* silent about shadow these days so, I frankly 
>don't know.
>
>If a patch is proposed, I can try integrating it (though it would be 
>better to integrate it upstream). I definitely can't create a patch 
>myself.

The attached patch fixes the bug. However, most likely it also reopens 
#605329.

-- 
Jakub Wilk
-------------- next part --------------
--- a/src/login.c
+++ b/src/login.c
@@ -126,12 +126,10 @@
 static void setup_tty (void);
 static void process_flags (int argc, char *const *argv);
 static /*@observer@*/const char *get_failent_user (/*@returned@*/const char *user);
-#ifndef USE_PAM
 static void update_utmp (const char *user,
                          const char *tty,
                          const char *host,
                          /*@null@*/const struct utmp *utent);
-#endif				/* ! USE_PAM */
 
 static struct faillog faillog;
 
@@ -473,7 +471,6 @@
 	return failent_user;
 }
 
-#ifndef USE_PAM
 /*
  * update_utmp - Update or create an utmp entry in utmp, wtmp, utmpw, and
  *               wtmpx
@@ -499,7 +496,6 @@
 	free (utx);
 #endif				/* USE_UTMPX */
 }
-#endif				/* ! USE_PAM */
 
 /*
  * login - create a new login session for a user
@@ -1239,13 +1235,11 @@
 		}
 	}
 
-#ifndef USE_PAM
 	/*
 	 * The utmp entry needs to be updated to indicate the new status
 	 * of the session, the new PID and SID.
 	 */
 	update_utmp (username, tty, hostname, utent);
-#endif				/* ! USE_PAM */
 
 	/* The pwd and spwd entries for the user have been copied.
 	 *