[Pkg-shadow-devel] [PATCH 04/11] Add backend support for suboridnate uids and gids

Eric W. Biederman ebiederm at xmission.com
Thu Jan 24 22:59:31 UTC 2013

Serge Hallyn <serge.hallyn at canonical.com> writes:

> Quoting Eric W. Biederman (ebiederm at xmission.com):
>> In practice it doesn't matter but it looks worth fixing for the sake of
>> long term maintenance.
> I figured the users must all be ok, and in practice it would work out,
> but the fact remains subsequent function calls assigning to local stack
> can overwrite what you've returned.  <shrug>

Yes.  Once I make rangebuf static then subordinate_parse is ok (at least
interface wise).  But the bug is real and I will get out an incremental
patch shortly.

The subordinate_parse really isn't ok as I claimed a minute ago I had
overlooked I copied everything into the local variable rangebuf before
processing.  In practice it works of course but that is luck.

> The rest of what I've looked over looked ok, thanks much!


Do you think you can start getting this into Ubuntu?


More information about the Pkg-shadow-devel mailing list