[Pkg-shadow-devel] Bug#750480: First patch looks ok

Serge Hallyn serge.hallyn at ubuntu.com
Wed Jun 25 19:34:02 UTC 2014

Since we are doing proper bounds checking on the snprintf result,
the worst thing that will happen if the size is too small is that
newuidmap and newgidmap will end up failing.  Note that moving
the comment explaining the max size up to the proc_dir_name
declaration would be more helpful.

For the same reason, simply doing

#ifndef PATH_MAX
#define PATH_MAX 512

would work just as well.

Adding a malloc is simply unjustified.

If Christian does not object I'll apply the patch in a bit to
upstream git.

More information about the Pkg-shadow-devel mailing list