[Pkg-shadow-devel] Newuidmap works with usernames instead of uids

[Serge Hallyn]

Thanks, looks good overall.  Note that you are not freeing
buf after you malloc it.  Also, where you

	sprintf(owner_uid_string, "%d", owner_pwd.pw_uid

should that be a %u ?

It is quite a shame as this will lengthen the failure case by
quite a bit, especially the 'two usernames with same uid'
concern.  But it seems necessary.

thanks,
-serge

Quoting Bostjan Skufca (bostjan at a2o.si):
> Change preview:
> https://github.com/bostjan/shadow/commit/1e2a7df18d12c5a4d58e47afa7e3087e009371ea
> 
> (I am already using it, works fine.)
> 
> b.
> 
> 
> 
> On 22 August 2014 23:19, Bostjan Skufca <bostjan at a2o.si> wrote:
> 
> > Tnx for reply.
> >
> > BTW: How do these two repo locations relate actually?
> > 1. git://anonscm.debian.org/git/pkg-shadow/shadow.git
> > 2. https://github.com/shadow-maint/shadow
> >
> > Second one seems stale (less activity in 2014, but it also does not seem
> > to be *just* lagging behind).
> >
> > b.
> >
> >
> >
> > On 22 August 2014 16:12, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> >
> >> Quoting Bostjan Skufca (bostjan at a2o.si):
> >> > Hi there,
> >> > (below I only describe situation for UIDs, but content also applies to
> >> GIDs)
> >> >
> >> > UID mapping feature only works if /etc/subuid contains exact username
> >> > definition. Contrary to expectations* it does not work if instead exact
> >> > username UID is used.
> >> >
> >> > Additionaly: It also does not work if mapping is requested by username,
> >> for
> >> > which there is no explicit configuration in /etc/subuid, but /etc/subuid
> >> > contains mapping definition for an username which shares the same UID
> >> with
> >> > original requesting username.
> >> >
> >> > Is this by design (using names instead of UIDs)?
> >> > If so, why?
> >> > Would you accept patches to at least enable mapping definitions which
> >> use
> >>
> >> Hi,
> >>
> >> nope doesn't seem to be by design, so patches appreciated.
> >>
> >> -serge
> >>
> >> > UIDs instead of usernames?
> >> >
> >> >
> >> > Thank you for your answer,
> >> > b.
> >> >
> >> > (*expectations: mine, not general, though this is debatable)
> >>
> >> > _______________________________________________
> >> > Pkg-shadow-devel mailing list
> >> > Pkg-shadow-devel at lists.alioth.debian.org
> >> >
> >> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-shadow-devel
> >>
> >>
> >