[Pkg-shadow-devel] Two warning while compiling pkg-shadow

[Serge Hallyn]

Quoting Boštjan Škufca @ Teon.si (bostjan at teon.si):
> When I run autogen, I get these warnings:
> 
> pkg-shadow# ./autogen.sh
> ...
> libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.in and
> ...
> libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
> ...
> 
> They can be fixed by this patch:
> 
> 
> diff --git a/Makefile.am b/Makefile.am
> index 7492f07..b40e925 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -4,5 +4,7 @@ EXTRA_DIST = NEWS README TODO shadow.spec.in
> 
>  AUTOMAKE_OPTIONS = 1.5 dist-bzip2 foreign
> 
> +ACLOCAL_AMFLAGS = -I m4
> +
>  SUBDIRS = po man libmisc lib src \
>         contrib doc etc
> diff --git a/configure.in b/configure.in
> index 1a3f841..b6c2026 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -2,6 +2,7 @@ dnl Process this file with autoconf to produce a configure
> script.
>  AC_INIT
>  AM_INIT_AUTOMAKE(shadow, 4.2)
>  AC_CONFIG_HEADERS([config.h])
> +AC_CONFIG_MACRO_DIR([m4])
> 
>  dnl Some hacks...
>  test "$prefix" = "NONE" && prefix="/usr"
> 
> 
> I am not really at home with autotools suite, so I do not know what impact
> will this have on other platforms.

I see this too.  I think the answer is that if adding these was going to
cause a problem, then we shouldn't shim m4/ to begin with.

-serge