[Pkg-shadow-devel] Lots of warnings in man/ directory

[Boštjan Škufca @ Teon.si]

Seems reasonable.

Maybe a short comment about this in Makefile.am (where one would
normally try to put this flag) would spare you from having to answer
the same question when next person starts looking into it:)

b.



--
Boštjan Škufca
Teon d.o.o. | http://teon.si



On 5 September 2014 17:54, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> Quoting Boštjan Škufca @ Teon.si (bostjan at teon.si):
>> When I run autogen.sh, I get lots of these warnings (not the same, but of
>> the same type):
>> # ./autogen.sh
>> ...
>> man/Makefile.am:181: addprefix login.defs.d/,$(login_defs_v: non-POSIX
>> variable name
>> man/Makefile.am:181: (probably a GNU make extension)
>> man/generate_mans.mak:30: `%'-style pattern rules are a GNU make extension
>> man/Makefile.am:208:   `man/generate_mans.mak' included from here
>> man/da/../generate_translations.mak:1: notdir $(CURDIR: non-POSIX variable
>> name
>> man/da/../generate_translations.mak:1: (probably a GNU make extension)
>> man/da/Makefile.am:31:   `man/da/../generate_translations.mak' included
>> from here
>> man/da/../generate_translations.mak:8: `%'-style pattern rules are a GNU
>> make extension
>> man/da/Makefile.am:31:   `man/da/../generate_translations.mak' included
>> from here
>> ...
>>
>> Adding "-Wno-portability" to AM_INIT_AUTOMAKE in main Makefile.am makes
>> them go away.
>> I don't think that it should be added to main Makefile.am, but to add it to
>> man/Makefile.am would probably be fine.
>>
>> What do you think? Does anybody else see these messages?
>
> No wait.  Now I do see these.
>
> It sounds like adding -Wno-portability papers over the problem.  I think
> we are better off leaving the warnings there until someone has time to
> walk through them and fix any which could really be a problem.