[Pkg-shadow-devel] Newuidmap works with usernames instead of uids

[Bostjan Skufca]

Excellent, Serge!

If I am not mistaken, there are no tests in the current repo, right?
There was some talk about them recently...

Anyway, as shadow tests are kinda hard to execute (might destroy the
host system, or careful chroot preparation is required), maybe it
would be best to settle for lxc-based tests (or whatever
containerization). I mean, not that everyone executes them, not at
all, but for those that want them (or need them, like people
developing patches) a lxc-based test suite is better than nothing.

My 2 cents.

b.

PS: I recently had a look at git sources for some reason, and the
new-feature-patch inclusion process outright rejects patches that do
not contain tests for new features. Not a bad thing, not at all, I
believe.


On 18 September 2014 00:25, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> Quoting Serge Hallyn (serge.hallyn at ubuntu.com):
>> Quoting Bostjan Skufca (bostjan at a2o.si):
>> > Very reasonable, fixed, pushed.
>> >
>> > b.
>>
>> Thanks, guys.  I'm going to give it one more close review then
>> push it to github.
>>
>> We should probably talk soon (in a separate thread) about a new
>> release (upstream and debian).  Maybe a bit more work with
>> testing should happen first...
>
> I've gone ahead and pushed them.  I built a package (on Ubuntu, just
> locally) and installed it.  Unprivileged containers still worked, and
> I verified that using my uid in /etc/subuid now worked fine.
>
> Thanks!
>
> -serge