[Pkg-shadow-devel] [PATCH v2 5/5] Allow creating shadow files, when missing, via an option.

[Dimitri John Ledkov]

Hello,

On 5 April 2015 at 03:50, Mike Frysinger <vapier at gentoo.org> wrote:
> On 01 Apr 2015 13:43, Dimitri John Ledkov wrote:
>> +#
>> +# Create shadow(5) and gshadow(5) files, when operations are invoked
>> +# that could modify those. E.g. passwd/useradd/userdel/usermod etc.
>> +# If this option is not set, shadow(5)/gshadow(5) files are updated,
>> +# only if already present on disk.
>> +#
>> +#
>> +#CREATE_SHADOW    yes
>> ...
>>  bool sgr_file_present (void)
>>  {
>> +     if (getdef_bool ("CREATE_SHADOW"))
>> +             return true;
>>       return commonio_present (&gshadow_db);
>>  }
>
> looks to me like you're changing the default ?  it is now disabled by default
> instead of enabled by default.
>

All options are disabled by default. The bit in the config file is
commented out, thus getdef_bool will return false by default. Thus the
presence of gsahdow_db will remain as the default condition as to
whether to use gshadow file or not. (same for shadow)

Should first hunk then instead be:

+#CREATE_SHADOW no

? And the manpage update, once this is settled.

> the new name looks OK to me

Thanks.


-- 
Regards,

Dimitri.

https://clearlinux.org
Open Source Technology Center
Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ.