[Pkg-shadow-devel] Bug#750480: Bug#750480: patch pushed

[Samuel Thibault]

Hello,

Serge Hallyn, le Thu 26 Jun 2014 21:51:30 +0000, a écrit :
> I've pushed the first patch to upstream git.  This should mean it will be
> fixed in the next merge into debian.

Could this be backported to Debian please?  We're still stuck with
version 1:4.1.5.1-1.1 on hurd-i386, and this makes the hurd-i386 buildds
get stuck when a package build hangs (e.g. a test loops), because
version 1:4.1.5.1-1.1 uses
kill(pid_child, caught)
while version 4.2 properly uses
kill(-pid_child, caught)

Samuel
-------------- next part --------------
Index: shadow-4.2/src/newuidmap.c
===================================================================
--- shadow-4.2.orig/src/newuidmap.c
+++ shadow-4.2/src/newuidmap.c
@@ -94,7 +94,7 @@ void usage(void)
  */
 int main(int argc, char **argv)
 {
-	char proc_dir_name[PATH_MAX];
+	char proc_dir_name[32];
 	char *target_str;
 	pid_t target, parent;
 	int proc_dir_fd;
@@ -120,6 +120,7 @@ int main(int argc, char **argv)
 	if (!get_pid(target_str, &target))
 		usage();
 
+	/* max string length is 6 + 10 + 1 + 1 = 18, allocate 32 bytes */
 	written = snprintf(proc_dir_name, sizeof(proc_dir_name), "/proc/%u/",
 		target);
 	if ((written <= 0) || (written >= sizeof(proc_dir_name))) {
Index: shadow-4.2/src/newgidmap.c
===================================================================
--- shadow-4.2.orig/src/newgidmap.c
+++ shadow-4.2/src/newgidmap.c
@@ -95,7 +95,7 @@ static void usage(void)
  */
 int main(int argc, char **argv)
 {
-	char proc_dir_name[PATH_MAX];
+	char proc_dir_name[32];
 	char *target_str;
 	pid_t target, parent;
 	int proc_dir_fd;
@@ -121,6 +121,7 @@ int main(int argc, char **argv)
 	if (!get_pid(target_str, &target))
 		usage();
 
+	/* max string length is 6 + 10 + 1 + 1 = 18, allocate 32 bytes */
 	written = snprintf(proc_dir_name, sizeof(proc_dir_name), "/proc/%u/",
 		target);
 	if ((written <= 0) || (written >= sizeof(proc_dir_name))) {