[Pkg-shadow-devel] Bug#816185: shadow: fails to build with --disable-subordinate-ids

[Samuel Thibault]

Source: shadow
Version: 1:4.2-3.1
Severity: normal
Tags: patch upstream

Hello,

This is rather for "upstream", but the meta-data of the debian package
seem to imply that Debian has become upstream, thus submitting this
report here.

For some reason I wanted to build with --disable-subordinate-ids, and it
failed for trivial reasons, please see attached patch.

Samuel

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
void packerFlushTheToiletFirstThingInTheMorning( void* arg )
 -+- chromium's source code -+-
-------------- next part --------------
--- ./src/usermod.c.original	2016-02-28 12:39:40.216062799 +0000
+++ ./src/usermod.c	2016-02-28 12:45:34.200309088 +0000
@@ -1361,6 +1361,7 @@
 		exit (E_UID_IN_USE);
 	}
 
+#ifdef ENABLE_SUBIDS
 	if (   (vflg || Vflg)
 	    && !is_sub_uid) {
 		fprintf (stderr,
@@ -1376,6 +1377,7 @@
 		         Prog, sub_gid_dbname (), "-w", "-W");
 		exit (E_USAGE);
 	}
+#endif
 }
 
 /*
--- src/Makefile.am.original	2016-02-28 12:53:30.869999858 +0000
+++ src/Makefile.am	2016-02-28 12:54:01.798368027 +0000
@@ -53,7 +53,10 @@
 noinst_PROGRAMS = id sulogin
 
 suidbins       = su
-suidubins      = chage chfn chsh expiry gpasswd newgrp passwd newuidmap newgidmap
+suidubins      = chage chfn chsh expiry gpasswd newgrp passwd
+if ENABLE_SUBIDS
+	suidubins += newuidmap newgidmap
+endif
 if ACCT_TOOLS_SETUID
 	suidubins += chage chgpasswd chpasswd groupadd groupdel groupmod newusers useradd userdel usermod
 endif