[Pkg-shadow-devel] out of my depth

[Mike Frysinger]

On 25 Nov 2016 13:42, Serge E. Hallyn wrote:
> On Tue, Nov 22, 2016 at 02:23:56AM +0100, Bálint Réczey wrote:
> > 2016-11-22 2:19 GMT+01:00 Serge E. Hallyn <serge at hallyn.com>:
> > > Quoting Bálint Réczey (balint at balintreczey.hu):
> > >> Hi Serge,
> > >>
> > >> I started reviewing the new package. The changes in Debian look good
> > >> but the generated
> > >> files in the original tarball do worry me.
> > >> Those are not present in tag 4.4 in upstream repository.
> > >
> > > Hi,
> > >
> > > Are you talking about the po/*.gmo files?  They keep getting
> > > autogenerated now witha 'make dist'.  That is what the first email
> > > in this thread was asking about, in particular:
> > >
> > > |>> autogen.sh calls autoreconf which calls autopoint, which creates
> > > |>> m4/po.m4, which creates po/Makefile.in.in, which creates a makefile
> > > |>> which ends up calling
> > > |>>
> > > |>> cd $(srcdir) && rm -f $${lang}.gmo && $(GMSGFMT) -c --statistics -o t-$${lang}.gmo $${lang}.po && mv t-$${lang}.gmo $${lang}.gmo
> > > |>>
> > > |>> etc.  The *.gmo files are binary ones, which we don't want to be
> > > |>> shipping iiuc.  So - what is an ignorant packager to do?  It seems
> > > |>> like there must be an obvious flag to add to autoreconf in autogen.sh,
> > > |>> but I can't find it.
> > >
> > > So they are not in the git tree but they are in fact in the upstream tarball.
> > > I could manually pull them out of the packaging source.orig.gz if that's
> > > the right thing to do...
> > 
> > 
> > Please don't use make dist.
> 
> Huh.  That's the first time I've heard that suggestion.

it's a bad suggestion in this case.  some people try to be super strict
in that the releases are always reproducible from git.  while that might
work for some projects, it doesn't for ones that use a generated build
system like autotools.  in order to pull it off, you'd have to actually
commit the generated output (e.g. "configure" and "config.h.in" and all
the rest) to git which is an even worse idea.

so when making shadow releases, you should be using `make distcheck`.
you can then attach the tarball to the github page under the releases
section.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-shadow-devel/attachments/20161127/c4d40071/attachment.sig>