[Pkg-shadow-devel] Bug#857803: Bug#857803: shadow: Make the sp_lstchg shadow field reproducible.

[Chris Lamb]

Serge E. Hallyn wrote:

> looks ok to me, although, would it be better to fall back to time(NULL)
> if the env variable is invalid?

In my experience it is far superior to explicitly error out in this
situation.

It's much better end-user debugging experience than the build "silently"
not being reproducible if (for whatever reason) S_D_E is invalid, especially
in terms of preventing regressions early.

> Do you want to submit this as a patch to upstream at
> github.com/shadow-maint/shadow ?

Very happy to once I get an ACK on the above.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-