[Pkg-shadow-devel] Contributing to shadow-uitls with pytest cases

[Anuj Borah]

On Fri, Apr 23, 2021 at 4:48 PM Iker Pedrosa <ipedrosa at redhat.com> wrote:

> Hi Anuj,
>
> I'm having difficulties understanding your proposal.
>
> On Fri, Apr 23, 2021 at 7:31 AM Anuj Borah <aborah at redhat.com> wrote:
>
>> Hi,
>>
>> After discussing with our team, we have decided that we will test and
>> review the pytest script on sssd CI platform then we will send the scripts
>> to : https://github.com/shadow-maint/shadow/tree/master/tests
>>
>> sssd repo: https://github.com/SSSD/sssd
>>
>>
> IIUC, you are proposing to check that the test scripts are correctly
> executed by opening a PR in sssd repository. But what about the peer
> review? Where will it happen? I think that the right place to do it is
> shadow-utils repository.
>

If we go ahead with this , Yes , scripts will be reviewed by sssd qe(sssd
PR) , then on shadow-utils repository(shadow-utils PR).


>
>
>>
>> This is because there are very few bash shadow utils test cases here with
>> us that will be ported to pytest and if we try to configure new CI on
>> shadow utils repo it will take much more time and effort , which does not
>> make sense for a very few test cases . Our sssd CI is configured and
>> working which we would like to utilize for this task .
>>
>> For every PR sent to shadow utils repo we will attach the PR send for CI
>> test and review on sssd repo.
>>
>
> IIUC, what you are proposing is that the shadow-utils PRs will have some
> type of mirror in the sssd repository to be able to test them using the CI
> included in that repository? Isn't this more difficult than configuring the
> CI directly in the shadow-utils repository?
>

As discussed with you, we will discuss this at our sssd meeting thurse day.


>
>
>>
>> Please let me know what you think ?
>>
>> Regards
>> Anuj Borah
>>
>>
>>
>>
>>
>> On Mon, Apr 19, 2021 at 5:20 PM Serge E. Hallyn <serge at hallyn.com> wrote:
>>
>>> On Mon, Apr 19, 2021 at 04:27:58PM +0530, Anuj Borah wrote:
>>> > Hi
>>> >
>>> > We have some bash test cases for shadow utils which we are porting to
>>> > pytest .
>>> >
>>> > I have visited :
>>> https://github.com/shadow-maint/shadow/tree/master/tests
>>> >
>>> > There I can see tests are in c and bash .
>>> >
>>> > So my questions will be :
>>> >
>>> > 1. Is it possible to put pytest cases on upstream shadow utils repo.
>>>
>>> Yes, that would be great.
>>>
>>> > 2. Is it possible to import our sssd test library there to run those
>>> test
>>> > cases on CI .
>>>
>>> Should be, yeah.
>>>
>>> > Please let me know.
>>> >
>>> >
>>> > Regards
>>> > Anuj Borah(redhat QE sssd )
>>>
>>> > _______________________________________________
>>> > Pkg-shadow-devel mailing list
>>> > Pkg-shadow-devel at alioth-lists.debian.net
>>> >
>>> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel
>>>
>>> _______________________________________________
>> Pkg-shadow-devel mailing list
>> Pkg-shadow-devel at alioth-lists.debian.net
>> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel
>>
>
>
> --
>
> Iker Pedrosa
>
> Software Engineer, Identity Management team
>
> Red Hat <https://www.redhat.com>
> <https://www.redhat.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-shadow-devel/attachments/20210423/46c99aff/attachment.htm>