[Pkg-shadow-devel] [Git][debian/adduser][wip/feature-system-locks] 45 commits: remove debian/tests/f/cronjack.t

Sat Jan 10 21:48:45 GMT 2026

Marc Haber pushed to branch wip/feature-system-locks at Debian / adduser

Commits:
5350d950 by Marc Haber at 2026-01-07T08:29:35+01:00
remove debian/tests/f/cronjack.t

useradd won't allow adding that user name any more

- - - - -
9f191f0d by Marc Haber at 2026-01-10T20:46:14+01:00
Depend on passwd 1:4.19.0-2

src:shadow 4.19.0 has tightened its user name checks. Our check
for the crontab hijack vulnerability is therefore no longer possible.
The change to src:shadow prevents that vulnerability earlier than we
could, so we depend on that version now.

- - - - -
80dacc4a by Marc Haber at 2026-01-10T21:26:27+01:00
Give chpasswd test values that it will accept

This is to work around the more picky chpasswd in new src:shadow

- - - - -
06a17f25 by Matt Barry at 2026-01-10T21:43:13+01:00
only set EXISTING_ID_MISMATCH if $new_[ug]id defined

- - - - -
9bfc41ef by Marc Haber at 2026-01-10T21:43:13+01:00
add new constants for password handling

Git-Dch: ignore
Thanks: Matt Barry

- - - - -
bae95b2c by Marc Haber at 2026-01-10T21:43:13+01:00
introduce password handling logic

Git-Dch: ignore
Thanks: Matt Barry

- - - - -
afff677f by Marc Haber at 2026-01-10T21:43:13+01:00
introduce new function existing_value_desc

Git-Dch: ignore
Thanks: Matt Barry

- - - - -
ef424328 by Marc Haber at 2026-01-10T21:43:13+01:00
use existing_value_desc

Thanks: Matt Barry
Git-Dch: ignore

- - - - -
4da77685 by Marc Haber at 2026-01-10T21:49:24+01:00
fix EXISTING_HAS_PASSWORD to correctly handle !

This now also handles !something in the password field

- - - - -
cc6deac0 by Marc Haber at 2026-01-10T21:51:12+01:00
move Marc's test10.pl to test11.pl to make Room

Git-Dch: ignore

- - - - -
194da632 by Marc Haber at 2026-01-10T21:51:12+01:00
add vim helper line to testsuite files

The files need to be reflowed when working on them next time

Git-Dch: ignore

- - - - -
cf45b9ce by Marc Haber at 2026-01-10T21:51:12+01:00
prepare upstream testsuite for EXISTING_

Git-Dch: ignore

- - - - -
97c856c0 by Marc Haber at 2026-01-10T21:51:12+01:00
various fixes in lib_test.pm

Git-Dch: ignore

- - - - -
19567f5e by Marc Haber at 2026-01-10T21:51:12+01:00
rework runsuite.sh

This now allows running a single test, and cleans up better

Git-Dch: ignore

- - - - -
dd8204ff by Marc Haber at 2026-01-10T21:51:12+01:00
make more clear that failure was expected

Git-Dch: ignore

- - - - -
818c8b4e by Marc Haber at 2026-01-10T22:09:27+01:00
improve log level handling

Thanks: Matt Barry
Git-Dch: ignore

- - - - -
9a7afedf by Marc Haber at 2026-01-10T22:09:53+01:00
fix EXISTING_HAS_PASSWORD to correctly handle !

This now also handles !something in the password field

- - - - -
c6ad46e9 by Marc Haber at 2026-01-10T22:09:56+01:00
clarify documentation of exit value 31

Git-Dch: ignore

- - - - -
a738da50 by Marc Haber at 2026-01-10T22:09:56+01:00
rename to RET_INVALID_CHARS_IN_INPUT, apply to comment as well

That was RET_INVALID_CHARS_IN_INPUT previously. The check is now
applied to the comment as well and the error message adapted.

Git-Dch: ignore

- - - - -
250d4251 by Marc Haber at 2026-01-10T22:09:56+01:00
move interactive command loops to a function

This is more streamlined and handles running on no terminal better

- - - - -
f3083896 by Marc Haber at 2026-01-10T22:33:14+01:00
re-work logic around remove-home etc

Git-Dch: ignore

- - - - -
4d58e74c by Marc Haber at 2026-01-10T22:33:14+01:00
prepare testsuite libraries to properly handle EXISTING_

this brings the simplifications to the test suite libraries

Git-Dch: ignore

- - - - -
e831856c by Marc Haber at 2026-01-10T22:33:14+01:00
add assert_path_is_a_file to debian/tests/lib

Git-Dch: ignore

- - - - -
2cc3da1a by Marc Haber at 2026-01-10T22:33:14+01:00
adapt test to new more picky src:shadow

Git-Dch: ignore

- - - - -
432432f7 by Marc Haber at 2026-01-10T22:33:14+01:00
test whether account is really gone.

Git-Dch: ignore

- - - - -
d82600ea by Matt Barry at 2026-01-10T22:39:37+01:00
deluser --lock [--system]

  * Add --lock/--unlock options for dealing with disabled accounts.
    See documentation.  Should probably have a notice specifically
    about behavioral changes (eg. adding/removing system accounts).

- - - - -
681f29f6 by Matt Barry at 2026-01-10T22:39:39+01:00
the documentation commit

this contains documentation changes related to account locking.
might still need some work.

- - - - -
9f5b8488 by Matt Barry at 2026-01-10T22:39:39+01:00
add some basic tests

- - - - -
ac0b71d5 by Matt Barry at 2026-01-10T22:40:57+01:00
locked.account.tests

- - - - -
bf359096 by Marc Haber at 2026-01-10T22:42:02+01:00
prepare AdduserTestsCommon for the new tests

Git-Dch: ignore

- - - - -
478ffda6 by Matt Barry at 2026-01-10T22:42:05+01:00
user locked account tests

Git-Dch: ignore

- - - - -
dca0371c by Marc Haber at 2026-01-10T22:42:05+01:00
fix testsuite warning in test08.pl

Git-Dch: ignore

- - - - -
fd8ce43b by Marc Haber at 2026-01-10T22:42:31+01:00
--unlock makes sense also for system accounts

This is consisten with the documentation

Git-Dch: ignore

- - - - -
690514c3 by Marc Haber at 2026-01-10T22:43:00+01:00
fix EXISTING_HAS_PASSWORD to correctly handle !

This now also handles !something in the password field

- - - - -
9373673c by Marc Haber at 2026-01-10T22:43:02+01:00
add unlock_user function

Git-Dch: ignore

- - - - -
d39ab698 by Marc Haber at 2026-01-10T22:43:02+01:00
error out if asked to add an already locked non-ystem user

Git-Dch: ignore

- - - - -
2375b67f by Marc Haber at 2026-01-10T22:43:02+01:00
unlock existing system user with new function

Git-Dch: ignore

- - - - -
f09f0d22 by Marc Haber at 2026-01-10T22:43:02+01:00
unlocking an existing system user is info

Git-Dch: ignore

- - - - -
04d14f42 by Marc Haber at 2026-01-10T22:43:02+01:00
implement adduser --unlock

Git-Dch: ignore

- - - - -
2230339d by Marc Haber at 2026-01-10T22:43:02+01:00
add AdduserStatefile.pm to maintain state file

- - - - -
ca1c978e by Marc Haber at 2026-01-10T22:43:02+01:00
install AdduserStatefile, remove state file on postrm

Git-Dch: ignore

- - - - -
67de7835 by Marc Haber at 2026-01-10T22:43:02+01:00
use AdduserStatefile

Git-Dch: ignore

- - - - -
41b4b109 by Marc Haber at 2026-01-10T22:43:21+01:00
prepare testsuite libraries to properly handle EXISTING_

this brings the simplifications to the test suite libraries

Git-Dch: ignore

- - - - -
1e6856cc by Marc Haber at 2026-01-10T22:43:23+01:00
remove ",,," from comment in test suite expectations

this must have been lost during some rebase.

Git-Dch: ignore

- - - - -
9c7a28cf by Marc Haber at 2026-01-10T22:45:24+01:00
test whether account is really gone.

Git-Dch: ignore

- - - - -

32 changed files:

- AdduserCommon.pm
- AdduserRetvalues.pm
- + AdduserStatefile.pm
- adduser
- adduser.conf
- debian/control
- debian/postrm
- debian/rules
- + debian/tests/f/account_locks.t
- debian/tests/f/adduser_system.t
- − debian/tests/f/cronjack.t
- debian/tests/lib/AdduserTestsCommon.pm
- deluser
- deluser.conf
- doc/adduser.8
- doc/deluser.8
- doc/deluser.conf.5
- + notes.100808x.md
- + testsuite/deluser-delete.conf
- testsuite/lib_test.pm
- testsuite/runsuite.sh
- testsuite/test01.pl
- testsuite/test02.pl
- testsuite/test03.pl
- testsuite/test04.pl
- testsuite/test05.pl
- testsuite/test06.pl
- testsuite/test07.pl
- testsuite/test08.pl
- testsuite/test09.pl
- testsuite/test10.pl
- + testsuite/test11.pl

The diff was not included because it is too large.

View it on GitLab: https://salsa.debian.org/debian/adduser/-/compare/ae6e8bd098bb0078e436c38fc0f7738362d312b8...9c7a28cf4ed366fe96585a5f4478f4a24ffe1db9

-- 
View it on GitLab: https://salsa.debian.org/debian/adduser/-/compare/ae6e8bd098bb0078e436c38fc0f7738362d312b8...9c7a28cf4ed366fe96585a5f4478f4a24ffe1db9
You're receiving this email because of your account on salsa.debian.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-shadow-devel/attachments/20260110/73ed909e/attachment-0001.htm>