Bug#549936: Bug#548126: pu: package opensaml2/2.0-2+lenny1

[Scott Cantor]

Faidon Liambotis wrote on 2009-10-07:
> Scott and Russ, under which conditions did you see the specific opensaml
> code to be inlined on shibboleth-sp2?

The version of opensaml released on the Internet2 site, which is 2.2.1, includes an inline version of the MetadataCredentialCriteria "matches" method with no .cpp file for that class in the source. That said, I can't say for certain where the implementation of that method ends up in the build.

> I just verified that the problem I initially described on #549936 was
> fixed when opensaml2 was upgraded.

That would mean the function implementation ended up in libsaml and the call to it from the SP wasn't inlined.

> It's definitely not inlined here (stock Debian packages + libsaml2
> update, amd64), hence no need for an upload of shibboleth-sp2.

It might be worth just scanning the libsaml binary for the function implementation using nm with demangling. I will take a closer look at a build on Red Hat myself.

I think Florian just assumed for safety's sake that it could be inlined, but it wasn't tested.

-- Scott