Bug#602328: libapache2-mod-shib2: apache should be restarted on install/upgrade

[Russ Allbery]

Ferenc Wagner <wferi at niif.hu> writes:
> Russ Allbery <rra at debian.org> writes:
>> Ferenc Wagner <wferi at niif.hu> writes:

>>> I can't find a specific tool in the a2(en/dis)mod family for checking
>>> the status of a module.  I hope it's correct to directly check for the
>>> /etc/apache2/mods-enabled/shib2.load symlink.

>> Yeah, I think that's fine.

> Btw. I wonder how if [ -f /etc/apache2/mods-enabled/shib.load ] could
> have possibly worked, ever.  Hasn't a2enmod always used symlinks instead
> of real files under mods-enabled?

-f will chase the symlink and see whether the link points to a real file.

> Anyway, when do you think we can get rid of all the legacy stuff in the
> postinst?

We can, but we shouldn't do that in a version that we're trying to push
into stable, since it's additional changes that aren't strictly necessary.

> I was also overwhelmed last week, but now I pushed something simple,
> please have a look.  I'm building it at the moment for some tests.  I
> hope there's still some chance of it getting through the Release Team...

The version number should still be -3 with both changes, but otherwise
that looks fine to me.  Although I think that -f is mildly better than -L,
since if it were a dangling symlink, I think Apache would just ignore it.

-- 
Russ Allbery (rra at debian.org)               <http://www.eyrie.org/~eagle/>