log4shib 1.0.9-3~bpo8+1

Ferenc Wágner wferi at niif.hu
Fri Aug 12 13:17:35 UTC 2016


Etienne Dysli-Metref <etienne.dysli-metref at switch.ch> writes:

> On 11/08/16 23:36, Ferenc Wágner wrote:
>
>> Looks good, though I'd rather see its Git history.
>
> Thanks for your review.
> Is there a place I can push to that wouldn't disrupt the Git history in
> case I need to rebase the branch I just pushed?

Easiest is to push to a temporary branch, which can be deleted
afterwards.  Or you can create a personal Alioth repo (see
https://wiki.debian.org/Alioth/Git) or a personal repo at any other
hosting site (I use GitHub for collaborating with GitHub upstreams).
Sending a bundle also works.  On a couple of occasions I even removed
objects from our repo, and nobody complained. :)

>> When reverting the GCC 5 ABI transition patch, take care not to
>> remove the NMU changelog entry (1.0.8-1.1) as well.
>
> Oh shoot! I removed it because I reverted c74236b. I thought it was fine
> since the transition isn't in jessie. But if you think such entries
> should stay I'll put it back in the changelog.

Yes please, because the packaging history actually contains that detour.
-- 
Feri



More information about the Pkg-shibboleth-devel mailing list