[xmltooling] 04/24: CPPXT-110 Clean up some collateral damage from previous checkin

Ferenc Wágner wferi at moszumanska.debian.org
Fri Dec 16 11:56:11 UTC 2016


This is an automated email from the git hooks/post-receive script.

wferi pushed a commit to branch master
in repository xmltooling.

commit c11212e5518454d9995e1c06f5defd2399df0596
Author: Rod Widdowson <rdw at steadingsoftware.com>
Date:   Tue Nov 1 16:33:10 2016 +0000

    CPPXT-110 Clean up some collateral damage from previous checkin
    
    https://issues.shibboleth.net/jira/browse/CPPXT-110
    
    Remove debugging printf that had escaped into the wild in
    SignatureTest.
    
    Change FilesystemCredentialResolverTest to reflect that there
    are three credentials in the test file.
---
 xmltoolingtest/FilesystemCredentialResolverTest.h | 2 +-
 xmltoolingtest/SignatureTest.h                    | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/xmltoolingtest/FilesystemCredentialResolverTest.h b/xmltoolingtest/FilesystemCredentialResolverTest.h
index 365c741..534f293 100644
--- a/xmltoolingtest/FilesystemCredentialResolverTest.h
+++ b/xmltoolingtest/FilesystemCredentialResolverTest.h
@@ -48,7 +48,7 @@ public:
         vector<const Credential*> creds;
         Locker locker(credResolver.get());
         credResolver->resolve(creds);
-        TSM_ASSERT_EQUALS("Retrieved credential was null", 1, creds.size());
+        TSM_ASSERT_EQUALS("Retrieved credential was null", 3, creds.size());
         TSM_ASSERT("Retrieved key was null", creds.front()->getPrivateKey()!=nullptr);
         TSM_ASSERT_EQUALS("Unexpected number of certificates", 1,
             dynamic_cast<const X509Credential*>(creds.front())->getEntityCertificateChain().size());
diff --git a/xmltoolingtest/SignatureTest.h b/xmltoolingtest/SignatureTest.h
index 718caf8..323c5fe 100644
--- a/xmltoolingtest/SignatureTest.h
+++ b/xmltoolingtest/SignatureTest.h
@@ -167,8 +167,6 @@ public:
         bool worked = dsaCred->verifyBase64Signature(toSign, sizeof(toSign), &outSig[0], len);
         TSM_ASSERT("DSA Round Trip Signature Failed", worked);
 
-        fprintf(stderr, "\n\n%s\n\n0x%x\n\n", outSig, len);
-
         char knownGoodSig[] = "bjl/jCGFdRgs0Ar5DKQkE9jPZFSXU5Wm2SKMzur4TSzoQmTe82WC8A==\012";
         unsigned int knownGoodSigSize=0x39;
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/xmltooling.git



More information about the Pkg-shibboleth-devel mailing list