[xmltooling] 10/24: CPPXT-110 Inverted parameters to TSM_ASSERT in DSA test

Ferenc Wágner wferi at moszumanska.debian.org
Fri Dec 16 11:56:12 UTC 2016


This is an automated email from the git hooks/post-receive script.

wferi pushed a commit to branch master
in repository xmltooling.

commit 167da50fd20d44803b3107aa116e60bc59cdabd3
Author: Rod Widdowson <rdw at steadingsoftware.com>
Date:   Sun Nov 20 10:48:47 2016 +0000

    CPPXT-110 Inverted parameters to TSM_ASSERT in DSA test
    
    https://issues.shibboleth.net/jira/browse/CPPXT-110
---
 xmltoolingtest/InlineKeyResolverTest.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/xmltoolingtest/InlineKeyResolverTest.h b/xmltoolingtest/InlineKeyResolverTest.h
index 69c7ce9..baaa5b3 100644
--- a/xmltoolingtest/InlineKeyResolverTest.h
+++ b/xmltoolingtest/InlineKeyResolverTest.h
@@ -120,10 +120,10 @@ public:
         unsigned int len = fileResolverDSA->signBase64Signature(toSign, 20, outSig, bufferSize);
 
         bool worked = fileResolverDSA->verifyBase64Signature(toSign, 20, outSig, len);
-        TSM_ASSERT(worked, "round trip file resolver DSA");
+        TSM_ASSERT("Round trip file resolver DSA failed", worked);
 
         worked = keyInfoDSA->verifyBase64Signature(toSign, 20, outSig, len);
-        TSM_ASSERT(worked, "round trip KeyInfo DSA");
+        TSM_ASSERT("Round trip KeyInfo DSA failed", worked);
 
     }
 
@@ -161,8 +161,7 @@ public:
         const int bufferSize = 1024;
         char outSig[bufferSize] = {0};
         unsigned int len = fileResolverCryptoKeyEC->signBase64SignatureDSA(toSign, sizeof(toSign), &outSig[0], bufferSize);
-        //bool worked = fileResolverCryptoKeyEC->verifyBase64SignatureDSA(toSign, sizeof(toSign), &outSig[0], len);
-        //TSM_ASSERT("EC Round Trip Signature Failed", worked);
+
         bool worked = sslCredFromKeyInfo->verifyBase64SignatureDSA(toSign, sizeof(toSign), &outSig[0], len);
         TSM_ASSERT("EC Round Trip Signature via KeyInfo Failed", worked);
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/xmltooling.git



More information about the Pkg-shibboleth-devel mailing list