Bug#814435: log4shib: FTBFS when built with dpkg-buildpackage -A (liblog4shib.la is not installed to anywhere)

[Santiago Vila]

Package: src:log4shib
Version: 1.0.9-2
User: sanvila at debian.org
Usertags: binary-indep
Severity: important

Dear maintainer:

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with autoreconf
   dh_testdir -i
   debian/rules override_dh_autoreconf
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_autoreconf --as-needed
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `config'.
libtoolize: copying file `config/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'

[... snipped ...]

/usr/bin/install -c -m 644 ./man/man3/log4shib_StringUtil.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::StringUtil.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_SyslogAppender.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::SyslogAppender.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_ThreadNameComponent.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::ThreadNameComponent.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_TimeStamp.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::TimeStamp.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_TimeStampComponent.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::TimeStampComponent.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_Win32DebugAppender.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::Win32DebugAppender.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_threading.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::threading.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_threading_MSMutex.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::threading::MSMutex.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_threading_MSScopedLock.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::threading::MSScopedLock.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_threading_Mutex.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::threading::Mutex.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_threading_ScopedLock.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::threading::ScopedLock.3
/usr/bin/install -c -m 644 ./man/man3/log4shib_threading_ThreadLocalDataHolder.3 /<<PKGBUILDDIR>>/debian/tmp/usr/share/man/man3/log4shib::threading::ThreadLocalDataHolder.3
/bin/bash /<<PKGBUILDDIR>>/config/install-sh -d /<<PKGBUILDDIR>>/debian/tmp/usr/share/doc/log4shib-1.0.9/api
cp -r html /<<PKGBUILDDIR>>/debian/tmp/usr/share/doc/log4shib-1.0.9/api
rm -f -r -f /<<PKGBUILDDIR>>/debian/tmp/usr/share/doc/log4shib-1.0.9/api/html/.svn /<<PKGBUILDDIR>>/debian/tmp/usr/share/doc/log4shib-1.0.9/api/html/Makefile*
make[4]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[2]: Leaving directory '/<<PKGBUILDDIR>>/doc'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
make[3]: Entering directory '/<<PKGBUILDDIR>>'
 /bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/bin'
 /usr/bin/install -c log4shib-config '/<<PKGBUILDDIR>>/debian/tmp/usr/bin'
 /bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/share/aclocal'
 /usr/bin/install -c -m 644 log4shib.m4 '/<<PKGBUILDDIR>>/debian/tmp/usr/share/aclocal'
 /bin/mkdir -p '/<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
 /usr/bin/install -c -m 644 log4shib.pc '/<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig'
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_install-indep
make[1]: Entering directory '/<<PKGBUILDDIR>>'
find debian/tmp/usr/share/doc/log4shib-*/api/html -name "*.md5" -delete
dh_install -Xman3 --fail-missing
dh_install: usr/lib/x86_64-linux-gnu/liblog4shib.la exists in debian/tmp but is not installed to anywhere
dh_install: missing files, aborting
debian/rules:31: recipe for target 'override_dh_install-indep' failed
make[1]: *** [override_dh_install-indep] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:38: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

Sorry not to have a fix, as I am reporting many bugs similar to
this one. The common hints are:

* If the only architecture-independent packages are dummy transitional
ones and they were released with jessie, the easy fix is to drop them
now.

* When using "dh", it is allowed to use (independently)
optional targets override_dh_foo-arch and override_dh_foo-indep
(for several values of "foo").


Once that both "dpkg-buildpackage -A" and "dpkg-buildpackage -B" work
properly, the package would be suitable to be uploaded in source-only
form if you wish.

Thanks.