[shibboleth-sp2] 97/100: Added a sanity check if cookie value has an equal sign in it.

Ferenc Wágner wferi-guest at moszumanska.debian.org
Tue Jan 26 21:29:21 UTC 2016


This is an automated email from the git hooks/post-receive script.

wferi-guest pushed a commit to annotated tag 1.2.1
in repository shibboleth-sp2.

commit ee47a4d02e16b5e58df149c84d80b416845e0829
Author: Scott Cantor <cantor.2 at osu.edu>
Date:   Thu Nov 4 20:31:54 2004 +0000

    Added a sanity check if cookie value has an equal sign in it.
---
 shib-target/shib-shire.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/shib-target/shib-shire.cpp b/shib-target/shib-shire.cpp
index eacb67a..e7d3a3c 100644
--- a/shib-target/shib-shire.cpp
+++ b/shib-target/shib-shire.cpp
@@ -374,6 +374,10 @@ RPCError* SHIRE::sessionIsValid(const char* session_id, const char* ip) const
     log.error ("No cookie value was provided");
     return new RPCError(SHIBRPC_NO_SESSION, "No cookie value was provided");
   }
+  else if (strchr(session_id,'=')) {
+    log.error ("The cookie value wasn't extracted successfully, use a more unique cookie name for your installation.");
+    return new RPCError(SHIBRPC_INTERNAL_ERROR, "The cookie value wasn't extracted successfully, use a more unique cookie name for your installation.");
+  }
 
   if (!ip || !*ip) {
     log.error ("Invalid IP Address");

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/shibboleth-sp2.git



More information about the Pkg-shibboleth-devel mailing list