[shibboleth-sp2] 11/119: Fix for empty values (#620)

[Ferenc Wágner]

This is an automated email from the git hooks/post-receive script.

wferi-guest pushed a commit to annotated tag 1.3.1
in repository shibboleth-sp2.

commit ce24bcb49f0492478b3c591636a34e5cad013e9b
Author: Scott Cantor <cantor.2 at osu.edu>
Date:   Thu Jan 25 17:44:20 2007 +0000

    Fix for empty values (#620)
---
 xmlproviders/XMLAAP.cpp | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/xmlproviders/XMLAAP.cpp b/xmlproviders/XMLAAP.cpp
index 83a6218..509e660 100644
--- a/xmlproviders/XMLAAP.cpp
+++ b/xmlproviders/XMLAAP.cpp
@@ -596,9 +596,14 @@ bool XMLAAPImpl::AttributeRule::accept(const DOMElement* e, const IScopedRoleDes
 
     if (log.isWarnEnabled()) {
         auto_ptr_char temp(m_name);
-        auto_ptr_char temp2(n->getNodeValue());
-        log.warn("%sattribute (%s) value (%s) could not be validated by policy, rejecting it",
-                 (bSimple ? "" : "complex "),temp.get(),temp2.get());
+        if (n) {
+            auto_ptr_char temp2(n->getNodeValue());
+            log.warn("%sattribute (%s) value (%s) could not be validated by policy, rejecting it",
+                     (bSimple ? "" : "complex "),temp.get(),temp2.get());
+        }
+        else {
+            log.warn("empty value in attribute (%s) is not valid SAML, rejecting", temp.get());
+        }
     }
     return false;
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/shibboleth-sp2.git