[shibboleth-sp2] 04/25: Stop freeing credential resolvers twice, when errors occur during initialization.

[Ferenc Wágner]

This is an automated email from the git hooks/post-receive script.

wferi-guest pushed a commit to annotated tag 1.3.2
in repository shibboleth-sp2.

commit 2d90f49e9c023b9598eddab0b1cc4a773f85b3d0
Author: Scott Cantor <cantor.2 at osu.edu>
Date:   Tue Apr 1 19:27:44 2008 +0000

    Stop freeing credential resolvers twice, when errors occur during initialization.
---
 xmlproviders/XMLCredentials.cpp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xmlproviders/XMLCredentials.cpp b/xmlproviders/XMLCredentials.cpp
index 8d67052..8e810c9 100644
--- a/xmlproviders/XMLCredentials.cpp
+++ b/xmlproviders/XMLCredentials.cpp
@@ -129,15 +129,11 @@ void XMLCredentialsImpl::init()
     }
     catch (SAMLException& e) {
         log.errorStream() << "Error while parsing creds configuration: " << e.what() << xmlproviders::logging::eol;
-        for (resolvermap_t::iterator j=m_resolverMap.begin(); j!=m_resolverMap.end(); j++)
-            delete j->second;
         throw;
     }
 #ifndef _DEBUG
     catch (...) {
         log.error("Unexpected error while parsing creds configuration");
-        for (resolvermap_t::iterator j=m_resolverMap.begin(); j!=m_resolverMap.end(); j++)
-            delete j->second;
         throw;
     }
 #endif

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/shibboleth-sp2.git