log4shib and pkg-config

Ferenc Wágner wferi at niif.hu
Wed Jun 22 13:48:23 UTC 2016


"Cantor, Scott" <cantor.2 at osu.edu> writes:

>> Would you consider incorporating such changes into xmltooling,
>> opensaml2 and shibboleth-sp2?
>
> Eventually, but I'm too close to release right now and don't have time
> to go back and test this (care to guess how Solaris will handle it?
> I'll give you a hint...). Please go ahead and file issues for it and
> I'll get back to it.

Sure, I'll do so.  No need to hurry this, I just wanted to know your
attitude towards the matter before investing considerable work into it.
Knowing you're willing to follow I'll just go ahead and gather some
experience for the next release cycle.

>> Anything else you'd prefer to have some other way?  It would be
>> possible to eliminate XMLTOOLING_LOG4SHIB and friends, or to keep
>> changing CFLAGS and LIBS instead of augmenting them where necessary,
>> or to hide the log4shib/log4cpp duality into further
>> defines/variables.
>
> I don't know how I could eliminate the define since the headers are
> simply different in the two cases, but maybe I don't know what you're
> suggesting.

I pondered something like renaming xmltooling/logging.h to logging.h.in
and moving all necessary include statements there like
#include <@log4lib@/OstreamAppender.h> etc.  Maybe not worth the
effort, though.

> I see the difference there with the flags. I suppose that is better at
> the end of the day since it eliminates the need to track flags
> separately in configure for different dependency sets.

Well, at least until you don't need those flags for doing test builds.
-- 
Feri



More information about the Pkg-shibboleth-devel mailing list