[shibboleth-sp2] 21/89: SSPCPP-695 - Memcache storage service does not correctly delete contexts

Ferenc Wágner wferi at moszumanska.debian.org
Thu Sep 1 09:24:04 UTC 2016


This is an automated email from the git hooks/post-receive script.

wferi pushed a commit to branch master
in repository shibboleth-sp2.

commit aac629d04087e8bfdf0fd9caced172b2023cb83a
Author: Scott Cantor <cantor.2 at osu.edu>
Date:   Tue May 10 22:01:48 2016 -0400

    SSPCPP-695 - Memcache storage service does not correctly delete contexts
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-695
---
 memcache-store/memcache-store.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/memcache-store/memcache-store.cpp b/memcache-store/memcache-store.cpp
index 8948e53..60e2802 100644
--- a/memcache-store/memcache-store.cpp
+++ b/memcache-store/memcache-store.cpp
@@ -429,7 +429,7 @@ bool MemcacheStorageService::createString(const char* context, const char* key,
 {
     m_log.debug("createString ctx: %s - key: %s", context, key);
 
-    string final_key = string(context) + ":" + string(key);
+    string final_key = string(context) + ':' + string(key);
 
     mc_record rec(value, expiration);
     string final_value;
@@ -535,7 +535,7 @@ int MemcacheStorageService::updateString(const char* context, const char* key, c
     }
 
     // Proceding with update
-    string final_key = string(context) + ":" + string(key);
+    string final_key = string(context) + ':' + string(key);
     mc_record rec(value, final_exp);
     string final_value;
     serialize(rec, final_value);
@@ -548,7 +548,7 @@ bool MemcacheStorageService::deleteString(const char* context, const char* key)
 {
     m_log.debug("deleteString ctx: %s - key: %s", context, key);
   
-    string final_key = string(context) + ":" + string(key);
+    string final_key = string(context) + ':' + string(key);
 
     // Not updating context map, if there is one. There is no need.
     return deleteMemcache(final_key.c_str(), 0);
@@ -612,7 +612,7 @@ void MemcacheStorageService::deleteContext(const char* context)
     
         m_log.debug("Iterating retrieved session map...");
         for (list<string>::const_iterator iter = contents.begin(); iter != contents.end(); ++iter) {
-            string final_key = map_name + *iter;
+            string final_key = map_name + ':' + *iter;
             deleteMemcache(final_key.c_str(), 0);
         }
     

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/shibboleth-sp2.git



More information about the Pkg-shibboleth-devel mailing list