[shibboleth-sp2] 03/19: SSPCPP-726 Fix condition's scoping

[Ferenc Wágner]

This is an automated email from the git hooks/post-receive script.

wferi pushed a commit to branch maint-2.6
in repository shibboleth-sp2.

commit ad1a68151065738fbe940897976b7a5418477697
Author: Rod Widdowson <rdw at steadingsoftware.com>
Date:   Tue Feb 14 11:35:34 2017 +0000

    SSPCPP-726 Fix condition's scoping
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-726
---
 shibsp/handler/impl/ExternalAuthHandler.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/shibsp/handler/impl/ExternalAuthHandler.cpp b/shibsp/handler/impl/ExternalAuthHandler.cpp
index c17ca1f..e6faca9 100644
--- a/shibsp/handler/impl/ExternalAuthHandler.cpp
+++ b/shibsp/handler/impl/ExternalAuthHandler.cpp
@@ -592,8 +592,10 @@ pair<bool,long> ExternalAuth::processMessage(
             }
         }
         os << " ]";
-        if (!target.empty())
-            os << ", \"RelayState\": "; json_safe(os, target.c_str());
+        if (!target.empty()) {
+            os << ", \"RelayState\": ";
+            json_safe(os, target.c_str());
+        }
         os << " }";
     }
     else {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/shibboleth-sp2.git