[shibboleth-sp2] 06/19: SSPCPP-705 Test against misconfigured AttributeChecker Handler

[Ferenc Wágner]

This is an automated email from the git hooks/post-receive script.

wferi pushed a commit to branch maint-2.6
in repository shibboleth-sp2.

commit 68a9cf9b331cd517b37bf149757fdf672374cc75
Author: Rod Widdowson <rdw at steadingsoftware.com>
Date:   Sat Feb 25 14:14:02 2017 +0000

    SSPCPP-705 Test against misconfigured AttributeChecker Handler
    
    https://issues.shibboleth.net/jira/browse/SSPCPP-705
---
 shibsp/handler/impl/AttributeCheckerHandler.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/shibsp/handler/impl/AttributeCheckerHandler.cpp b/shibsp/handler/impl/AttributeCheckerHandler.cpp
index d4b86a9..a46194e 100644
--- a/shibsp/handler/impl/AttributeCheckerHandler.cpp
+++ b/shibsp/handler/impl/AttributeCheckerHandler.cpp
@@ -128,6 +128,9 @@ AttributeCheckerHandler::AttributeCheckerHandler(const DOMElement* e, const char
         if (m_attributes.empty())
             throw ConfigurationException("AttributeChecker unable to parse attributes setting.");
     }
+    else if (nullptr == XMLHelper::getFirstChildElement(e)) {
+        throw ConfigurationException("AttributeChecker requires either the attributes setting or an ACL");
+    }
     else {
         m_acl.reset(SPConfig::getConfig().AccessControlManager.newPlugin(XML_ACCESS_CONTROL, e));
     }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-shibboleth/shibboleth-sp2.git