Bug#925978: shibboleth-sp2-common: fills up the /var/cache directory with incommon-metadata.xml.XXXX

[Cantor, Scott]

On 3/31/19, 10:44 AM, "Ferenc Wagner,,, on behalf of wferi at niif.hu" <wferi at niif.hu> wrote:

>  However, I'm somewhat confused about the fix: [1] says it's a "one character fix", but d2e6d712 is a
> little more elaborate.  How do these fit together?

The bulk of the problem was a missing ampersand in this line:

     feedqueue_t& q = m_feedQueues[application.getHash()];

There were other problems contributing but they wouldn't have been as noticeable without that mistake. The code as it is now is basically what should be used. But if you're not planning to backport it, it doesn't really matter.
 
-- Scott