Bug#984327: shibboleth-sp: ftbfs with GCC-11

[Matthias Klose]

Package: src:shibboleth-sp
Version: 3.2.0+dfsg1-2
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/shibboleth-sp_3.2.0+dfsg1-2_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
  149 |         throw(std::invalid_argument);
      |         ^~~~~
In file included from /usr/include/log4shib/Appender.hh:21,
                 from /usr/include/log4shib/Category.hh:14,
                 from /usr/include/xmltooling/logging.h:34,
                 from ../shibsp/TransactionLog.h:33,
                 from SPConfig.h:34,
                 from internal.h:50,
                 from AbstractSPRequest.cpp:27:
/usr/include/log4shib/Priority.hh:106:9: error: ISO C++17 does not allow dynamic exception specifications
  106 |         throw(std::invalid_argument);
      |         ^~~~~
In file included from /usr/include/xmltooling/logging.h:34,
                 from ../shibsp/TransactionLog.h:33,
                 from SPConfig.h:34,
                 from internal.h:50,
                 from AbstractSPRequest.cpp:27:
/usr/include/log4shib/Category.hh:115:9: error: ISO C++17 does not allow dynamic exception specifications
  115 |         throw(std::invalid_argument);
      |         ^~~~~
/usr/include/log4shib/Category.hh:149:9: error: ISO C++17 does not allow dynamic exception specifications
  149 |         throw(std::invalid_argument);
      |         ^~~~~
In file included from /usr/include/log4shib/Appender.hh:21,
                 from /usr/include/log4shib/Category.hh:14,
                 from /usr/include/xmltooling/logging.h:34,
                 from ../shibsp/TransactionLog.h:33,
                 from SPConfig.h:34,
                 from internal.h:50,
                 from ServiceProvider.cpp:27:
/usr/include/log4shib/Priority.hh:106:9: error: ISO C++17 does not allow dynamic exception specifications
  106 |         throw(std::invalid_argument);
      |         ^~~~~
In file included from /usr/include/xmltooling/logging.h:34,
                 from ../shibsp/TransactionLog.h:33,
                 from SPConfig.h:34,
                 from internal.h:50,
                 from ServiceProvider.cpp:27:
/usr/include/log4shib/Category.hh:115:9: error: ISO C++17 does not allow dynamic exception specifications
  115 |         throw(std::invalid_argument);
      |         ^~~~~
/usr/include/log4shib/Category.hh:149:9: error: ISO C++17 does not allow dynamic exception specifications
  149 |         throw(std::invalid_argument);
      |         ^~~~~
Application.cpp: In member function ‘virtual void shibsp::Application::limitRedirect(const xmltooling::GenericRequest&, const char*) const’:
Application.cpp:174:55: warning: unused parameter ‘request’ [-Wunused-parameter]
  174 | void Application::limitRedirect(const GenericRequest& request, const char* url) const
      |                                 ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
Application.cpp:174:76: warning: unused parameter ‘url’ [-Wunused-parameter]
  174 | void Application::limitRedirect(const GenericRequest& request, const char* url) const
      |                                                                ~~~~~~~~~~~~^~~
make[4]: *** [Makefile:2424: libshibsp_la-Application.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [Makefile:2438: libshibsp_la-SPConfig.lo] Error 1
AbstractSPRequest.cpp: In member function ‘virtual void shibsp::AbstractSPRequest::setAuthType(const char*)’:
AbstractSPRequest.cpp:313:49: warning: unused parameter ‘authtype’ [-Wunused-parameter]
  313 | void AbstractSPRequest::setAuthType(const char* authtype)
      |                                     ~~~~~~~~~~~~^~~~~~~~
make[4]: *** [Makefile:2417: libshibsp_la-AbstractSPRequest.lo] Error 1
make[4]: *** [Makefile:2431: libshibsp_la-ServiceProvider.lo] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/shibsp'
make[3]: *** [Makefile:1121: all] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/shibsp'
make[2]: *** [Makefile:658: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:562: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:19: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2