Bug#1062895: shibboleth-sp: NMU diff for 64-bit time_t transition

[Sergio Durigan Junior]

Source: shibboleth-sp
Version: 3.4.1+dfsg-2
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-arm at lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
shibboleth-sp as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for shibboleth-sp
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-5-amd64 (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
-------------- next part --------------
diff -Nru shibboleth-sp-3.4.1+dfsg/debian/changelog shibboleth-sp-3.4.1+dfsg/debian/changelog
--- shibboleth-sp-3.4.1+dfsg/debian/changelog	2023-01-30 07:04:53.000000000 +0000
+++ shibboleth-sp-3.4.1+dfsg/debian/changelog	2024-02-03 21:55:43.000000000 +0000
@@ -1,3 +1,10 @@
+shibboleth-sp (3.4.1+dfsg-2.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Sergio Durigan Junior <sergiodj at debian.org>  Sat, 03 Feb 2024 21:55:43 +0000
+
 shibboleth-sp (3.4.1+dfsg-2) unstable; urgency=medium
 
   * Upload to unstable
diff -Nru shibboleth-sp-3.4.1+dfsg/debian/control shibboleth-sp-3.4.1+dfsg/debian/control
--- shibboleth-sp-3.4.1+dfsg/debian/control	2023-01-22 13:20:06.000000000 +0000
+++ shibboleth-sp-3.4.1+dfsg/debian/control	2024-02-03 21:55:43.000000000 +0000
@@ -56,7 +56,10 @@
  (web servers providing resources protected by Shibboleth) and the
  supporting shibd daemon.
 
-Package: libshibsp11
+Package: libshibsp11t64
+Provides: ${t64:Provides}
+Replaces: libshibsp11
+Breaks: libshibsp11 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -90,7 +93,7 @@
 Multi-Arch: same
 Depends:
  libsaml-dev (>= 3.2~),
- libshibsp11 (= ${binary:Version}),
+ libshibsp11t64 (= ${binary:Version}),
  libxerces-c-dev,
  libxmltooling-dev (>= 3.2~),
  ${misc:Depends},
diff -Nru shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.install shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.install
--- shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.install	2023-01-22 13:20:06.000000000 +0000
+++ shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.install	1970-01-01 00:00:00.000000000 +0000
@@ -1,2 +0,0 @@
-usr/lib/*/libshibsp.so.*
-usr/lib/*/libshibsp-lite.so.*
diff -Nru shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.lintian-overrides shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.lintian-overrides
--- shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.lintian-overrides	2023-01-22 13:20:06.000000000 +0000
+++ shibboleth-sp-3.4.1+dfsg/debian/libshibsp11.lintian-overrides	1970-01-01 00:00:00.000000000 +0000
@@ -1,5 +0,0 @@
-# See https://wiki.debian.org/UsingSymbolsFiles and follow to
-# https://www.eyrie.org/~eagle/journal/2012-02/001.html.
-# In short: symbols files are not worth providing for Shibboleth.
-no-symbols-control-file usr/lib/*/libshibsp.so.*
-no-symbols-control-file usr/lib/*/libshibsp-lite.so.*
diff -Nru shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.install shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.install
--- shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.install	1970-01-01 00:00:00.000000000 +0000
+++ shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.install	2023-01-22 13:20:06.000000000 +0000
@@ -0,0 +1,2 @@
+usr/lib/*/libshibsp.so.*
+usr/lib/*/libshibsp-lite.so.*
diff -Nru shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.lintian-overrides shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.lintian-overrides
--- shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.lintian-overrides	1970-01-01 00:00:00.000000000 +0000
+++ shibboleth-sp-3.4.1+dfsg/debian/libshibsp11t64.lintian-overrides	2024-02-03 21:55:43.000000000 +0000
@@ -0,0 +1,6 @@
+# See https://wiki.debian.org/UsingSymbolsFiles and follow to
+# https://www.eyrie.org/~eagle/journal/2012-02/001.html.
+# In short: symbols files are not worth providing for Shibboleth.
+no-symbols-control-file usr/lib/*/libshibsp.so.*
+no-symbols-control-file usr/lib/*/libshibsp-lite.so.*
+libshibsp11t64: package-name-doesnt-match-sonames libshibsp11