[Pkg-sogo-maintainers] Bug#1094184: sope: FTCBFS: multiple reasons

[Yavor Doganov]

Source: sope
Version: 5.11.1-1
Severity: minor
Control: block -1 with 1094178
Tags: patch
User: debian-cross at lists.debian.org
Usertags: cross-satisfiability ftcbfs

I tried building the sope package on amd64 for armhf, using the
GNUstep core packages that will be available soon in experimental
(only gnustep-make/2.9.2-5 is there at the time of filing).  The
sope package has the same unsatisfiable build-depends problem as
described in sbjson's #1094173.

In addition, with the above problem fixed, the configure script fails
with the following output:

creating: /build/reproducible-path/sope-5.11.1/config.make
failed to link optional library: xml2
failed to link optional library: ldap
failed to link required library: ssl
make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 1

That's because the build architecture compiler is used.  A simple fix
is to include config.mk from the gnustep-make package (which we at the
GNUstep team always do because it simplifies things a lot and fixes
problems like this one).  This shortens debian/rules as well and adds
support for "noopt" and "terse" (although your upstream overrides the
former in some makefiles, so I'm not sure it works in practice).

I marked this bug as blocking #1094178 because the patch there is its
parent, and because it doesn't make sense applying it if that bug is
not fixed.  It's not possible to cross-build current GNUstep, and
that's one of the reasons we're doing this transition.
-------------- next part --------------
>From 383a77ad4e94e900f7d48a2f485fb88b2a18d4da Mon Sep 17 00:00:00 2001
From: Yavor Doganov <yavor at gnu.org>
Date: Sat, 25 Jan 2025 18:54:51 +0200
Subject: [PATCH] Fix FTCBFS.

---
 debian/changelog | 7 ++++++-
 debian/control   | 1 -
 debian/rules     | 9 ++-------
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index fd77596..cc257bb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,10 +1,15 @@
 sope (5.11.1-2) UNRELEASED; urgency=medium
 
   * debian/control (Build-Depends): Require libgnustep-base-dev (>=
-    1.30.0-10) for the multiarch layout.
+    1.30.0-10) for the multiarch layout.  Remove unnecessary gobjc.
     (libsope1): Mark as Multi-Arch: same.
   * debian/libsope1.install: Update for the multiarch layout.
   * debian/libsope-dev.install: Likewise.
+  * debian/rules: Include /usr/share/GNUstep/debian/config.mk to avoid
+    using the build architecture Objective-C compiler.  Fixes FTCBFS.
+    (override_dh_auto_build): Use dh_auto_build and pass $(optim) and
+    $(verbose) to support noopt and terse in DEB_BUILD_OyPTIONS.
+    (override_dh_auto_install): Remove; no longer necessary.
 
  -- Yavor Doganov <yavor at gnu.org>  Wed, 15 Jan 2025 00:05:08 +0200
 
diff --git a/debian/control b/debian/control
index 63fd56e..5a408e1 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,6 @@ Uploaders: Jeroen Dekkers <jeroen at dekkers.ch>,
            Jordi Mallach <jordi at debian.org>
 Build-Depends: debhelper-compat (= 13),
  gnustep-make,
- gobjc,
  libgnustep-base-dev (>= 1.30.0-10),
  libxml2-dev,
  libldap2-dev,
diff --git a/debian/rules b/debian/rules
index e5c5075..ae63c40 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,6 +4,7 @@ export DH_VERBOSE=1
 
 export DEB_BUILD_MAINT_OPTIONS=hardening=+bindnow
 include /usr/share/dpkg/buildflags.mk
+include /usr/share/GNUstep/debian/config.mk
 
 %:
 	dh $@
@@ -17,13 +18,7 @@ override_dh_auto_configure:
 	./configure --disable-strip --with-gnustep --with-ssl=ssl
 
 override_dh_auto_build:
-	$(MAKE) all messages=yes OBJCFLAGS="$(CFLAGS)"
-
-override_dh_auto_install:
-	GNUSTEP_MAKEFILES=/usr/share/GNUstep/Makefiles $(MAKE) install \
-		messages=yes OBJCFLAGS="$(CFLAGS)" \
-		DESTDIR=$(CURDIR)/debian/tmp/ \
-		GNUSTEP_INSTALLATION_DOMAIN=SYSTEM
+	dh_auto_build -- $(optim) $(verbose) OBJCFLAGS="$(CFLAGS)"
 
 # This will make sure that the SOGo binary packages will always depend
 # on the latest SOPE
-- 
2.47.2