[Pkg-sssd-devel] Bug#1060180: Bug#1060180: uid-wrapper: cmocka does not set CMOCKA_LIBRARY anymore.

[Simon Josefsson]

Hefee <hefee at debian.org> writes:

> Package: uid-wrapper
> Version: 1.3.0-4
> Severity: normal
> Tags: patch
> X-Debbugs-Cc: hefee at debian.org
>
> Hey,
>
> cmocka does not set CMOCKA_LIBRARY anymore with 1.1.6+. You can easly
> use cmoka as library name. I tested the attached patch locally and it
> makes the autopkgtests pass again.
>
> Additionally enables VERBOSE=1 for make, so it is easier to spot what
> command is actually executed.

Hi.

Is this patch still relevant and necessary?  How to reproduce the
problem?  I think upstream's fix like this resolve this:

https://gitlab.com/cwrap/uid_wrapper/-/commit/850f24c6366abda30bfd77734b90330b8809d306

So unless there is some more information, I think this bug report can be
closed as fixed in 1.3.0-5.  We'll see once the autopkgtest runs for the
recent 1.3.1-1 upload if there are any cmake errors.

The VERBOSE=1 part was added here:
https://salsa.debian.org/sssd-team/uid-wrapper/-/commit/979e902813975791d93eff8f1d3fca3037846bb6

/Simon

>
> Regards,
>
> hefee
>
> diff --git a/debian/tests/tests b/debian/tests/tests
> index b2b4504..a5adfa6 100755
> --- a/debian/tests/tests
> +++ b/debian/tests/tests
> @@ -6,7 +6,7 @@ rm -rf obj debian
>  mkdir obj
>  cd obj
>  cmake .. -DUNIT_TESTING=1
> -make -C tests/
> +make VERBOSE=1 -C tests/
>  cd tests
>  sed -e 's#\(LD_PRELOAD=[^:]*\)[^;]*/\(libuid_wrapper.so\)#\1:\2#' -i CTestTestfile.cmake
>  make test ARGS="--output-on-failure"
> diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
> index 635e86e..0398261 100644
> --- a/tests/CMakeLists.txt
> +++ b/tests/CMakeLists.txt
> @@ -59,7 +59,7 @@ function(ADD_CMOCKA_TEST_ENVIRONMENT _TEST_NAME)
>                      ENVIRONMENT "${TORTURE_ENVIRONMENT}")
>  endfunction()
>  
> -set(TESTSUITE_LIBRARIES ${UWRAP_REQUIRED_LIBRARIES} ${CMOCKA_LIBRARY})
> +set(TESTSUITE_LIBRARIES ${UWRAP_REQUIRED_LIBRARIES} cmocka)
>  
>  if (BSD)
>      add_definitions(-DBSD)
>
> _______________________________________________
> Pkg-sssd-devel mailing list
> Pkg-sssd-devel at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-sssd-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 255 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-sssd-devel/attachments/20240923/e0704c70/attachment.sig>