[Pkg-sssd-devel] Bug#1069450: Follow up on bug #1069450

[Chen Shengqi]

(Resend to BTS only, since my last mail got rejected.)

-----Original Message-----
To: 1069450 at bugs.debian.org; Andrew Bartlett <abartlet at samba.org>; Lucas Nussbaum <lucas at debian.org>; Luca Boccassi <bluca at debian.org>; Simon Josefsson <simon at josefsson.org>; Helge Deller <deller at gmx.de>

Hi all,

socket-wrapper still fails its tests on armel and armhf, also blocking its
(and all dependencies') migration to testing. Since trixie freeze is coming
soon, I think we should try to fix this soon.

The failed autopkgtest [1] (take test_swrap_unit as example) actually passes on
build [2]. The offending -D_FILE_OFFSET_BITS=64 (and friends) in the command line
comes from upstream tests/CMakeLists.txt:

if (CMAKE_SIZEOF_VOID_P EQUAL 4)
    execute_process(
        COMMAND getconf LFS_CFLAGS
        OUTPUT_VARIABLE GETCONF_LFS_CFLAGS
        OUTPUT_STRIP_TRAILING_WHITESPACE)
    # Create a list from the string
    set(LFS_CFLAGS)
    if (GETCONF_LFS_CFLAGS)
        string(REPLACE " " ";" LFS_CFLAGS ${GETCONF_LFS_CFLAGS})
    endif()
    message(STATUS "Enabling large file support for tests: ${LFS_CFLAGS}")
endif()

And it is inverted (to be confirmed) by -U_FILE_OFFSET_BITS set by dpkg-buildflags
when abi=-time64 is specified when building. They are not set any more when
running autopkgtest, so things would go south.

I would recommend using consistent build flags in autopkgtest script, i.e., adding
something looking like in d/tests/tests:

export DEB_BUILD_MAINT_OPTIONS=abi=-time64
export CFLAGS=$(dpkg-buildflags --get CFLAGS)
export CPPFLAGS=$(dpkg-buildflags --get CPPFLAGS)

[1]: https://ci.debian.net/packages/s/socket-wrapper/testing/armhf/57471265/
[2]: https://buildd.debian.org/status/fetch.php?pkg=socket-wrapper&arch=armhf&ver=1.4.3-2&stamp=1730834460&raw=0

-- 
Thanks,
Shengqi Chen